[PATCH v1] pintctrl: merrifield: Add I²S bus 2 pins to groups and functions

[PATCH v1] pintctrl: merrifield: Add I²S bus 2 pins to groups and functions

[Andy Shevchenko]

It is useful to control I²S bus 2 pins if we would like to connect
an audio codec.

Reported-by: mouse <xllacyx@gmail.com>
Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-merrifield.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/pinctrl/intel/pinctrl-merrifield.c b/drivers/pinctrl/intel/pinctrl-merrifield.c
index 04ca8ae95df8..84da1b746fb8 100644
--- a/drivers/pinctrl/intel/pinctrl-merrifield.c
+++ b/drivers/pinctrl/intel/pinctrl-merrifield.c
@@ -339,6 +339,7 @@ static const struct pinctrl_pin_desc mrfld_pins[] = {
 	/* Family 18: Broadcast (0 pins) */
 };
 
+static const unsigned int mrfld_i2s2_pins[] = { 40, 41, 42, 43 };
 static const unsigned int mrfld_sdio_pins[] = { 50, 51, 52, 53, 54, 55, 56 };
 static const unsigned int mrfld_spi5_pins[] = { 90, 91, 92, 93, 94, 95, 96 };
 static const unsigned int mrfld_uart0_pins[] = { 115, 116, 117, 118 };
@@ -350,6 +351,7 @@ static const unsigned int mrfld_pwm2_pins[] = { 132 };
 static const unsigned int mrfld_pwm3_pins[] = { 133 };
 
 static const struct intel_pingroup mrfld_groups[] = {
+	PIN_GROUP("i2s2_grp", mrfld_i2s2_pins, 1),
 	PIN_GROUP("sdio_grp", mrfld_sdio_pins, 1),
 	PIN_GROUP("spi5_grp", mrfld_spi5_pins, 1),
 	PIN_GROUP("uart0_grp", mrfld_uart0_pins, 1),
@@ -361,6 +363,7 @@ static const struct intel_pingroup mrfld_groups[] = {
 	PIN_GROUP("pwm3_grp", mrfld_pwm3_pins, 1),
 };
 
+static const char * const mrfld_i2s2_groups[] = { "i2s2_grp" };
 static const char * const mrfld_sdio_groups[] = { "sdio_grp" };
 static const char * const mrfld_spi5_groups[] = { "spi5_grp" };
 static const char * const mrfld_uart0_groups[] = { "uart0_grp" };
@@ -372,6 +375,7 @@ static const char * const mrfld_pwm2_groups[] = { "pwm2_grp" };
 static const char * const mrfld_pwm3_groups[] = { "pwm3_grp" };
 
 static const struct intel_function mrfld_functions[] = {
+	FUNCTION("i2s2", mrfld_i2s2_groups),
 	FUNCTION("sdio", mrfld_sdio_groups),
 	FUNCTION("spi5", mrfld_spi5_groups),
 	FUNCTION("uart0", mrfld_uart0_groups),
-- 
2.27.0.rc2

Re: [PATCH v1] pintctrl: merrifield: Add I²S bus 2 pins to groups and functions

[Mika Westerberg]

On Thu, Jun 04, 2020 at 12:28:07PM +0300, Andy Shevchenko wrote:
> It is useful to control I²S bus 2 pins if we would like to connect
> an audio codec.
> 
> Reported-by: mouse <xllacyx@gmail.com>
> Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Re: [PATCH v1] pintctrl: merrifield: Add I²S bus 2 pins to groups and functions

[Andy Shevchenko]

On Thu, Jun 04, 2020 at 12:52:24PM +0300, Mika Westerberg wrote:
> On Thu, Jun 04, 2020 at 12:28:07PM +0300, Andy Shevchenko wrote:
> > It is useful to control I²S bus 2 pins if we would like to connect
> > an audio codec.
> > 
> > Reported-by: mouse <xllacyx@gmail.com>
> > Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko