From: Kent Gibson <warthog618@gmail.com>
To: linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com, ml@ionscale.com
Cc: Kent Gibson <warthog618@gmail.com>
Subject: [PATCH 2/3] tests: event: add tests for gpiod_line_get_value_bulk events
Date: Wed, 17 Jun 2020 11:06:38 +0800 [thread overview]
Message-ID: <20200617030639.27690-3-warthog618@gmail.com> (raw)
In-Reply-To: <20200617030639.27690-1-warthog618@gmail.com>
Add tests to verify the behaviour of gpiod_line_get_value_bulk when
applied to a bulk of event lines.
Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
In v1.5 only the value of the first line is returned correctly.
tests/tests-event.c | 110 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 110 insertions(+)
diff --git a/tests/tests-event.c b/tests/tests-event.c
index b59c995..e323060 100644
--- a/tests/tests-event.c
+++ b/tests/tests-event.c
@@ -421,6 +421,116 @@ GPIOD_TEST_CASE(get_value_active_low, 0, { 8 })
g_assert_cmpint(ev.event_type, ==, GPIOD_LINE_EVENT_FALLING_EDGE);
}
+GPIOD_TEST_CASE(get_values, 0, { 8 })
+{
+ g_autoptr(gpiod_chip_struct) chip = NULL;
+ struct gpiod_line_bulk bulk;
+ struct gpiod_line *line;
+ gint i, ret, vals[8];
+
+ chip = gpiod_chip_open(gpiod_test_chip_path(0));
+ g_assert_nonnull(chip);
+ gpiod_test_return_if_failed();
+
+ gpiod_line_bulk_init(&bulk);
+ for (i = 0; i < 8; i++) {
+ line = gpiod_chip_get_line(chip, i);
+ g_assert_nonnull(line);
+ gpiod_test_return_if_failed();
+
+ gpiod_line_bulk_add(&bulk, line);
+ gpiod_test_chip_set_pull(0, i, 1);
+ }
+
+ ret = gpiod_line_request_bulk_rising_edge_events(&bulk,
+ GPIOD_TEST_CONSUMER);
+ g_assert_cmpint(ret, ==, 0);
+
+ memset(vals, 0, sizeof(vals));
+ ret = gpiod_line_get_value_bulk(&bulk, vals);
+ g_assert_cmpint(ret, ==, 0);
+ g_assert_cmpint(vals[0], ==, 1);
+ g_assert_cmpint(vals[1], ==, 1);
+ g_assert_cmpint(vals[2], ==, 1);
+ g_assert_cmpint(vals[3], ==, 1);
+ g_assert_cmpint(vals[4], ==, 1);
+ g_assert_cmpint(vals[5], ==, 1);
+ g_assert_cmpint(vals[6], ==, 1);
+ g_assert_cmpint(vals[7], ==, 1);
+
+ gpiod_test_chip_set_pull(0, 1, 0);
+ gpiod_test_chip_set_pull(0, 3, 0);
+ gpiod_test_chip_set_pull(0, 4, 0);
+ gpiod_test_chip_set_pull(0, 7, 0);
+
+ memset(vals, 0, sizeof(vals));
+ ret = gpiod_line_get_value_bulk(&bulk, vals);
+ g_assert_cmpint(ret, ==, 0);
+ g_assert_cmpint(vals[0], ==, 1);
+ g_assert_cmpint(vals[1], ==, 0);
+ g_assert_cmpint(vals[2], ==, 1);
+ g_assert_cmpint(vals[3], ==, 0);
+ g_assert_cmpint(vals[4], ==, 0);
+ g_assert_cmpint(vals[5], ==, 1);
+ g_assert_cmpint(vals[6], ==, 1);
+ g_assert_cmpint(vals[7], ==, 0);
+}
+
+GPIOD_TEST_CASE(get_values_active_low, 0, { 8 })
+{
+ g_autoptr(gpiod_chip_struct) chip = NULL;
+ struct gpiod_line_bulk bulk;
+ struct gpiod_line *line;
+ gint i, ret, vals[8];
+
+ chip = gpiod_chip_open(gpiod_test_chip_path(0));
+ g_assert_nonnull(chip);
+ gpiod_test_return_if_failed();
+
+ gpiod_line_bulk_init(&bulk);
+ for (i = 0; i < 8; i++) {
+ line = gpiod_chip_get_line(chip, i);
+ g_assert_nonnull(line);
+ gpiod_test_return_if_failed();
+
+ gpiod_line_bulk_add(&bulk, line);
+ gpiod_test_chip_set_pull(0, i, 0);
+ }
+
+ ret = gpiod_line_request_bulk_rising_edge_events_flags(&bulk,
+ GPIOD_TEST_CONSUMER, GPIOD_LINE_REQUEST_FLAG_ACTIVE_LOW);
+ g_assert_cmpint(ret, ==, 0);
+
+ memset(vals, 0, sizeof(vals));
+ ret = gpiod_line_get_value_bulk(&bulk, vals);
+ g_assert_cmpint(ret, ==, 0);
+ g_assert_cmpint(vals[0], ==, 1);
+ g_assert_cmpint(vals[1], ==, 1);
+ g_assert_cmpint(vals[2], ==, 1);
+ g_assert_cmpint(vals[3], ==, 1);
+ g_assert_cmpint(vals[4], ==, 1);
+ g_assert_cmpint(vals[5], ==, 1);
+ g_assert_cmpint(vals[6], ==, 1);
+ g_assert_cmpint(vals[7], ==, 1);
+
+ gpiod_test_chip_set_pull(0, 1, 1);
+ gpiod_test_chip_set_pull(0, 3, 1);
+ gpiod_test_chip_set_pull(0, 4, 1);
+ gpiod_test_chip_set_pull(0, 7, 1);
+
+ memset(vals, 0, sizeof(vals));
+ ret = gpiod_line_get_value_bulk(&bulk, vals);
+ g_assert_cmpint(ret, ==, 0);
+ g_assert_cmpint(vals[0], ==, 1);
+ g_assert_cmpint(vals[1], ==, 0);
+ g_assert_cmpint(vals[2], ==, 1);
+ g_assert_cmpint(vals[3], ==, 0);
+ g_assert_cmpint(vals[4], ==, 0);
+ g_assert_cmpint(vals[5], ==, 1);
+ g_assert_cmpint(vals[6], ==, 1);
+ g_assert_cmpint(vals[7], ==, 0);
+}
+
GPIOD_TEST_CASE(wait_multiple, 0, { 8 })
{
g_autoptr(GpiodTestEventThread) ev_thread = NULL;
--
2.27.0
next prev parent reply other threads:[~2020-06-17 3:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 3:06 [libgpiod][PATCH 0/3] fix get_values for events Kent Gibson
2020-06-17 3:06 ` [PATCH 1/3] bindings: cxx: tests: add tests for bulk events get_values Kent Gibson
2020-06-17 3:06 ` Kent Gibson [this message]
2020-06-17 3:06 ` [PATCH 3/3] core: fix gpiod_line_get_value_bulk for events Kent Gibson
2020-06-17 12:45 ` [libgpiod][PATCH 0/3] fix get_values " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617030639.27690-3-warthog618@gmail.com \
--to=warthog618@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linux-gpio@vger.kernel.org \
--cc=ml@ionscale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).