* [gpio:gpiochip-no-driver-h 4/4] drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c:91:6: warning: variable 'err' is uninitialized when used here
@ 2020-07-09 17:19 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2020-07-09 17:19 UTC (permalink / raw)
To: Linus Walleij; +Cc: kbuild-all, clang-built-linux, linux-gpio
[-- Attachment #1: Type: text/plain, Size: 7540 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git gpiochip-no-driver-h
head: 76089802fe1b5db2ac8ad21da3b065f2513000eb
commit: 76089802fe1b5db2ac8ad21da3b065f2513000eb [4/4] unremove
config: mips-randconfig-r012-20200709 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 02946de3802d3bc65bc9f2eb9b8d4969b5a7add8)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
git checkout 76089802fe1b5db2ac8ad21da3b065f2513000eb
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c:91:6: warning: variable 'err' is uninitialized when used here [-Wuninitialized]
err);
^~~
include/net/cfg80211.h:7837:35: note: expanded from macro 'wiphy_err'
dev_err(&(wiphy)->dev, format, ##args)
^~~~
include/linux/dev_printk.h:104:32: note: expanded from macro 'dev_err'
_dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c:53:12: note: initialize the variable 'err' to silence this warning
int i, err;
^
= 0
1 warning generated.
vim +/err +91 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 50
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 51 int brcms_led_register(struct brcms_info *wl)
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 52 {
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 53 int i, err;
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 54 struct brcms_led *radio_led = &wl->radio_led;
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 55 /* get CC core */
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 56 struct bcma_drv_cc *cc_drv = &wl->wlc->hw->d11core->bus->drv_cc;
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 57 struct gpio_chip *bcma_gpio = &cc_drv->gpio;
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 58 struct ssb_sprom *sprom = &wl->wlc->hw->d11core->bus->sprom;
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 59 u8 *leds[] = { &sprom->gpio0,
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 60 &sprom->gpio1,
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 61 &sprom->gpio2,
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 62 &sprom->gpio3 };
bac167c2b9d351 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c Linus Walleij 2020-07-06 63 int hwnum = -1;
bac167c2b9d351 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c Linus Walleij 2020-07-06 64 enum gpio_lookup_flags lflags = GPIO_ACTIVE_HIGH;
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 65
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 66 if (!bcma_gpio || !gpio_is_valid(bcma_gpio->base))
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 67 return -ENODEV;
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 68
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 69 /* find radio enabled LED */
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 70 for (i = 0; i < BRCMS_LED_NO; i++) {
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 71 u8 led = *leds[i];
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 72 if ((led & BRCMS_LED_BEH_MASK) == BRCMS_LED_RADIO) {
bac167c2b9d351 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c Linus Walleij 2020-07-06 73 hwnum = i;
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 74 if (led & BRCMS_LED_AL_MASK)
bac167c2b9d351 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c Linus Walleij 2020-07-06 75 lflags = GPIO_ACTIVE_LOW;
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 76 break;
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 77 }
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 78 }
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 79
bac167c2b9d351 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c Linus Walleij 2020-07-06 80 /* No LED, bail out */
bac167c2b9d351 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c Linus Walleij 2020-07-06 81 if (hwnum == -1)
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 82 return -ENODEV;
cd864522b349cf drivers/net/wireless/brcm80211/brcmsmac/led.c Piotr Haber 2013-03-03 83
bac167c2b9d351 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c Linus Walleij 2020-07-06 84 /* Try to obtain this LED GPIO line */
bac167c2b9d351 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c Linus Walleij 2020-07-06 85 radio_led->gpiod = gpiochip_request_own_desc(bcma_gpio, hwnum,
bac167c2b9d351 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c Linus Walleij 2020-07-06 86 "radio on", lflags,
bac167c2b9d351 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c Linus Walleij 2020-07-06 87 GPIOD_OUT_LOW);
bac167c2b9d351 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c Linus Walleij 2020-07-06 88
bac167c2b9d351 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c Linus Walleij 2020-07-06 89 if (IS_ERR(radio_led->gpiod)) {
bac167c2b9d351 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c Linus Walleij 2020-07-06 90 wiphy_err(wl->wiphy, "requesting led GPIO failed (err: %d)\n",
bac167c2b9d351 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c Linus Walleij 2020-07-06 @91 err);
:::::: The code at line 91 was first introduced by commit
:::::: bac167c2b9d351703c4f769f9feabfae89bac789 brcm80211: brcmsmac: Move LEDs to GPIO descriptors
:::::: TO: Linus Walleij <linus.walleij@linaro.org>
:::::: CC: Linus Walleij <linus.walleij@linaro.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30265 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-09 17:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-09 17:19 [gpio:gpiochip-no-driver-h 4/4] drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c:91:6: warning: variable 'err' is uninitialized when used here kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).