From: Gary Bisson <gary.bisson@boundarydevices.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [libgpiod][PATCH 3/3] Android.bp: initial addition
Date: Tue, 18 Aug 2020 18:05:03 +0200 [thread overview]
Message-ID: <20200818160503.GB500735@p1g2> (raw)
In-Reply-To: <CAMRc=MecqRb-=qeudU2=fMGi3yujuz5qYDruni6+fv8EALu_ig@mail.gmail.com>
Hi,
On Tue, Aug 18, 2020 at 06:01:13PM +0200, Bartosz Golaszewski wrote:
> On Mon, Aug 17, 2020 at 6:24 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
>
> [snip]
>
> > > >
> > > > I don't know Android very well but if its build system can launch
> > > > autotools, then maybe you could autotoolify this file by providing
> > > > Android.bp.in and letting autotools expand this macro?
> > >
> > > No unfortunately that is not how the AOSP build system works (or at
> > > least I'm not aware of it).
> > > AFAIK all the open-source projects used in AOSP (see external/ folder)
> > > have a separate Android.bp alongside the autotools files.
> > >
> > > Here are a few examples of Android.bp files added by Google to
> > > well-known projects:
> > > - curl [1]
> > > - iputils [2]
> > > - strace [3]
> > >
> > > In the case above it is up to Google to maintain that file as only
> > > hosted on their servers (not merged upstream).
> > > But some other projects are ok merging it which makes it easier (at
> > > least for me) like can-utils [4].
> > >
> >
> > I'm perfectly fine with merging this file but I don't like having
> > another place to look at when bumping the version number. I bunched up
> > all API and ABI versions together in configure.ac in order to not
> > forget anything when making new releases.
> >
> > I'm sure Android's build system is not as limited as not to allow to
> > run some external scripts that would at least fetch the current
> > version from configure.ac, is it?
> >
>
> Can you do something like this[1] but make the command fetch the
> version string from configure.ac?
>
> Bartosz
>
> [1] http://androidxref.com/9.0.0_r3/xref/external/libmojo/Android.bp#67
Yes I'll try to come up with something that get the version from
configure.ac. Same as the other patch, might be only next week.
Thanks,
Gary
prev parent reply other threads:[~2020-08-18 16:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 9:06 [libgpiod][PATCH 0/3] Add Android build support Gary Bisson
2020-06-08 9:06 ` [libgpiod][PATCH 1/3] core: add missing header inclusion Gary Bisson
2020-06-08 9:06 ` [libgpiod][PATCH 2/3] tools-common: fix build for Android Gary Bisson
2020-08-10 19:15 ` Bartosz Golaszewski
2020-08-17 8:23 ` Gary Bisson
2020-08-17 13:04 ` Bartosz Golaszewski
2020-08-18 16:04 ` Gary Bisson
2020-06-08 9:06 ` [libgpiod][PATCH 3/3] Android.bp: initial addition Gary Bisson
2020-08-10 19:51 ` Bartosz Golaszewski
2020-08-17 8:38 ` Gary Bisson
2020-08-17 16:24 ` Bartosz Golaszewski
2020-08-18 16:01 ` Bartosz Golaszewski
2020-08-18 16:05 ` Gary Bisson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818160503.GB500735@p1g2 \
--to=gary.bisson@boundarydevices.com \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).