From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v6 11/20] gpiolib: cdev: support GPIO_V2_LINE_SET_VALUES_IOCTL
Date: Thu, 3 Sep 2020 17:31:20 +0800 [thread overview]
Message-ID: <20200903093120.GA160697@sol> (raw)
In-Reply-To: <CAMpxmJWYpDQsvKCsNudb6p3zAey=6EuNpb3wQ3dpCJVCTjjBsg@mail.gmail.com>
On Thu, Sep 03, 2020 at 09:59:17AM +0200, Bartosz Golaszewski wrote:
> On Mon, Aug 31, 2020 at 5:23 AM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > Add support for the GPIO_V2_LINE_SET_VALUES_IOCTL.
> >
> > Signed-off-by: Kent Gibson <warthog618@gmail.com>
> > ---
> > drivers/gpio/gpiolib-cdev.c | 59 +++++++++++++++++++++++++++++++++++++
> > 1 file changed, 59 insertions(+)
> >
> > diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> > index 936b8c9958dd..9f05bbd2161e 100644
> > --- a/drivers/gpio/gpiolib-cdev.c
> > +++ b/drivers/gpio/gpiolib-cdev.c
> > @@ -777,6 +777,63 @@ static long linereq_get_values(struct linereq *lr, void __user *ip)
> > return 0;
> > }
> >
> > +static long linereq_set_values_unlocked(struct linereq *lr,
> > + struct gpio_v2_line_values *lv)
> > +{
> > + DECLARE_BITMAP(vals, GPIO_V2_LINES_MAX);
> > + struct gpio_desc **descs;
> > + unsigned int i, didx, num_set;
> > + int ret;
> > +
> > + bitmap_zero(vals, GPIO_V2_LINES_MAX);
> > + for (num_set = 0, i = 0; i < lr->num_lines; i++) {
> > + if (lv->mask & BIT_ULL(i)) {
> > + if (!test_bit(FLAG_IS_OUT, &lr->lines[i].desc->flags))
> > + return -EPERM;
> > + if (lv->bits & BIT_ULL(i))
> > + __set_bit(num_set, vals);
> > + num_set++;
> > + descs = &lr->lines[i].desc;
> > + }
> > + }
> > + if (num_set == 0)
> > + return -EINVAL;
> > +
> > + if (num_set != 1) {
> > + /* build compacted desc array and values */
> > + descs = kmalloc_array(num_set, sizeof(*descs), GFP_KERNEL);
>
> Missing retval check.
>
Arrgh, that has been there since PATCH v2!
And subsequently got propagated into patch 07 :-(.
Kent.
next prev parent reply other threads:[~2020-09-03 9:31 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 3:19 [PATCH v6 00/20] gpio: cdev: add uAPI v2 Kent Gibson
2020-08-31 3:19 ` [PATCH v6 01/20] gpiolib: cdev: desc_to_lineinfo should set info offset Kent Gibson
2020-08-31 3:19 ` [PATCH v6 02/20] gpiolib: cdev: replace strncpy with strscpy Kent Gibson
2020-08-31 3:19 ` [PATCH v6 03/20] gpio: uapi: define GPIO_MAX_NAME_SIZE for array sizes Kent Gibson
2020-08-31 3:19 ` [PATCH v6 04/20] gpio: uapi: define uAPI v2 Kent Gibson
2020-09-04 6:23 ` Bartosz Golaszewski
2020-08-31 3:19 ` [PATCH v6 05/20] gpiolib: make cdev a build option Kent Gibson
2020-08-31 3:19 ` [PATCH v6 06/20] gpiolib: add build option for CDEV v1 ABI Kent Gibson
2020-08-31 3:19 ` [PATCH v6 07/20] gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPIO_V2_LINE_GET_VALUES_IOCTL Kent Gibson
2020-09-03 7:42 ` Bartosz Golaszewski
2020-08-31 3:19 ` [PATCH v6 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL Kent Gibson
2020-08-31 3:19 ` [PATCH v6 09/20] gpiolib: cdev: support edge detection for uAPI v2 Kent Gibson
2020-09-03 7:55 ` Bartosz Golaszewski
2020-09-03 8:09 ` Kent Gibson
2020-09-03 8:13 ` Bartosz Golaszewski
2020-08-31 3:19 ` [PATCH v6 10/20] gpiolib: cdev: support GPIO_V2_LINE_SET_CONFIG_IOCTL Kent Gibson
2020-08-31 3:19 ` [PATCH v6 11/20] gpiolib: cdev: support GPIO_V2_LINE_SET_VALUES_IOCTL Kent Gibson
2020-09-03 7:59 ` Bartosz Golaszewski
2020-09-03 9:31 ` Kent Gibson [this message]
2020-08-31 3:19 ` [PATCH v6 12/20] gpiolib: cdev: support setting debounce Kent Gibson
2020-08-31 3:19 ` [PATCH v6 13/20] gpio: uapi: document uAPI v1 as deprecated Kent Gibson
2020-08-31 3:20 ` [PATCH v6 14/20] tools: gpio: port lsgpio to v2 uAPI Kent Gibson
2020-08-31 3:20 ` [PATCH v6 15/20] tools: gpio: port gpio-watch " Kent Gibson
2020-08-31 3:20 ` [PATCH v6 16/20] tools: gpio: rename nlines to num_lines Kent Gibson
2020-08-31 3:20 ` [PATCH v6 17/20] tools: gpio: port gpio-hammer to v2 uAPI Kent Gibson
2020-08-31 3:20 ` [PATCH v6 18/20] tools: gpio: port gpio-event-mon " Kent Gibson
2020-08-31 3:20 ` [PATCH v6 19/20] tools: gpio: add multi-line monitoring to gpio-event-mon Kent Gibson
2020-08-31 3:20 ` [PATCH v6 20/20] tools: gpio: add debounce support " Kent Gibson
2020-09-03 8:02 ` [PATCH v6 00/20] gpio: cdev: add uAPI v2 Bartosz Golaszewski
2020-09-03 8:37 ` Kent Gibson
2020-09-04 12:52 ` Kent Gibson
2020-09-04 13:02 ` Bartosz Golaszewski
2020-09-08 15:24 ` Shuah Khan
2020-09-08 15:54 ` Bartosz Golaszewski
2020-09-08 16:04 ` Shuah Khan
2020-09-09 1:09 ` Kent Gibson
2020-09-09 1:15 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903093120.GA160697@sol \
--to=warthog618@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).