From: Lee Jones <lee.jones@linaro.org>
To: dillon.minfei@gmail.com
Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH: V2 2/2] gpio: tc35894: Disable Direct KBD interrupts to enable gpio irq
Date: Tue, 8 Sep 2020 15:04:15 +0100 [thread overview]
Message-ID: <20200908140415.GW4400@dell> (raw)
In-Reply-To: <1599118222-18990-3-git-send-email-dillon.minfei@gmail.com>
On Thu, 03 Sep 2020, dillon.minfei@gmail.com wrote:
> From: dillon min <dillon.minfei@gmail.com>
>
> On tc35894, have to disable direct keypad interrupts to make
> it as general purpose interrupts functionality work.
> if not, after chip reset, IRQST(0x91) will always 0x20,
> IRQN always low level, can't be clear.
>
> Configure DIRECTx to enable general purpose gpio mode,
> else read GPIOMISx register always zero in irq routine.
>
> verified on tc35894, need more test on other tc3589x.
>
> Signed-off-by: dillon min <dillon.minfei@gmail.com>
> ---
>
> V1 -> V2:
> Add DIRECTx register configuration to active general purpose gpio mode.
>
> drivers/gpio/gpio-tc3589x.c | 18 ++++++++++++++++--
> include/linux/mfd/tc3589x.h | 6 ++++++
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-09-08 16:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 7:30 [PATCH: V2 0/2] Fix TC35894 gpio interrupt bug dillon.minfei
2020-09-03 7:30 ` [PATCH: V2 1/2] gpio: tc35894: fix up tc35894 interrupt configuration dillon.minfei
2020-09-09 9:34 ` Bartosz Golaszewski
2020-09-03 7:30 ` [PATCH: V2 2/2] gpio: tc35894: Disable Direct KBD interrupts to enable gpio irq dillon.minfei
2020-09-08 14:04 ` Lee Jones [this message]
2020-09-09 9:33 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908140415.GW4400@dell \
--to=lee.jones@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=dillon.minfei@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).