From: Kent Gibson <warthog618@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v9 00/20] gpio: cdev: add uAPI v2
Date: Thu, 24 Sep 2020 16:00:14 +0800 [thread overview]
Message-ID: <20200924080014.GD17562@sol> (raw)
In-Reply-To: <CAHp75VeXbTkSTVgrqmeL_taEHPDBMo-rekA767Y+YT1_7RYjdg@mail.gmail.com>
On Wed, Sep 23, 2020 at 07:35:30PM +0300, Andy Shevchenko wrote:
> On Tue, Sep 22, 2020 at 5:34 AM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > This patchset defines and implements a new version of the
> > GPIO CDEV uAPI to address existing 32/64-bit alignment issues, add
> > support for debounce, event sequence numbers, and allow for requested
> > lines with different configurations.
> > It provides some future proofing by adding optional configuration fields
> > and padding reserved for future use.
> >
> > The series can be partitioned into three blocks; the first two patches
> > are minor fixes that impact later patches, the next eleven contain the
> > v2 uAPI definition and implementation, and the final seven port the GPIO
> > tools to the v2 uAPI and extend them to use new uAPI features.
> >
> > The more complicated patches include their own commentary where
> > appropriate.
>
> For tools (there are minor comments, which not prevent to have a tag):
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> For the rest I gave some comments but most of them are simply to
> address. The uAPI definition I agree with after Arnd's comment. I
> don't see big impediments to having this for v5.10.
>
> Thanks!
>
Thanks for your review - I nearly always learn something new from them,
and you can be picky pain in the arse at times - which is a good thing
for a reviewer. Apart from the pain in the arse ;-).
Cheers,
Kent.
next prev parent reply other threads:[~2020-09-24 8:00 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 2:31 [PATCH v9 00/20] gpio: cdev: add uAPI v2 Kent Gibson
2020-09-22 2:31 ` [PATCH v9 01/20] gpiolib: cdev: gpio_desc_to_lineinfo() should set info offset Kent Gibson
2020-09-22 2:31 ` [PATCH v9 02/20] gpiolib: cdev: replace strncpy() with strscpy() Kent Gibson
2020-09-22 2:31 ` [PATCH v9 03/20] gpio: uapi: define GPIO_MAX_NAME_SIZE for array sizes Kent Gibson
2020-09-22 2:31 ` [PATCH v9 04/20] gpio: uapi: define uAPI v2 Kent Gibson
2020-09-22 7:41 ` Arnd Bergmann
2020-09-22 9:50 ` Bartosz Golaszewski
2020-09-22 10:07 ` Kent Gibson
2020-09-28 13:42 ` strace decoding for GPIO uAPI Kent Gibson
2020-09-29 13:20 ` Bartosz Golaszewski
2020-09-29 15:04 ` Kent Gibson
2020-09-29 16:19 ` Andy Shevchenko
2020-09-23 10:04 ` [PATCH v9 04/20] gpio: uapi: define uAPI v2 Andy Shevchenko
2020-09-23 10:30 ` Kent Gibson
2020-09-23 11:16 ` Andy Shevchenko
2020-09-23 12:18 ` Arnd Bergmann
2020-09-23 15:15 ` Andy Shevchenko
2020-09-22 2:31 ` [PATCH v9 05/20] gpiolib: make cdev a build option Kent Gibson
2020-09-22 2:31 ` [PATCH v9 06/20] gpiolib: add build option for CDEV v1 ABI Kent Gibson
2020-09-22 2:31 ` [PATCH v9 07/20] gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPIO_V2_LINE_GET_VALUES_IOCTL Kent Gibson
2020-09-23 11:11 ` Andy Shevchenko
2020-09-24 8:09 ` Kent Gibson
2020-09-25 10:06 ` Andy Shevchenko
2020-09-26 9:16 ` Kent Gibson
2020-09-27 9:00 ` Andy Shevchenko
2020-09-27 12:39 ` Kent Gibson
2020-09-24 14:29 ` Bartosz Golaszewski
2020-09-22 2:31 ` [PATCH v9 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL Kent Gibson
2020-09-23 15:41 ` Andy Shevchenko
2020-09-24 2:39 ` Kent Gibson
2020-09-24 8:39 ` Andy Shevchenko
2020-09-24 9:48 ` Kent Gibson
2020-09-25 10:12 ` Andy Shevchenko
2020-09-25 11:56 ` Kent Gibson
2020-09-25 14:43 ` Andy Shevchenko
2020-09-25 5:32 ` Kent Gibson
2020-09-22 2:31 ` [PATCH v9 09/20] gpiolib: cdev: support edge detection for uAPI v2 Kent Gibson
2020-09-23 15:47 ` Andy Shevchenko
2020-09-24 3:07 ` Kent Gibson
2020-09-25 9:35 ` Andy Shevchenko
2020-09-25 12:26 ` Kent Gibson
2020-09-25 14:48 ` Andy Shevchenko
2020-09-22 2:31 ` [PATCH v9 10/20] gpiolib: cdev: support GPIO_V2_LINE_SET_CONFIG_IOCTL Kent Gibson
2020-09-23 16:14 ` Andy Shevchenko
2020-09-23 16:15 ` Andy Shevchenko
2020-09-24 3:24 ` Kent Gibson
2020-09-24 8:26 ` Andy Shevchenko
2020-09-24 9:26 ` Kent Gibson
2020-09-25 9:49 ` Andy Shevchenko
2020-09-22 2:31 ` [PATCH v9 11/20] gpiolib: cdev: support GPIO_V2_LINE_SET_VALUES_IOCTL Kent Gibson
2020-09-23 16:18 ` Andy Shevchenko
2020-09-24 7:32 ` Kent Gibson
2020-09-24 8:21 ` Andy Shevchenko
2020-09-24 9:08 ` Kent Gibson
2020-09-24 12:46 ` Kent Gibson
2020-09-25 9:57 ` Andy Shevchenko
2020-09-25 12:16 ` Kent Gibson
2020-09-22 2:31 ` [PATCH v9 12/20] gpiolib: cdev: support setting debounce Kent Gibson
2020-09-23 16:27 ` Andy Shevchenko
2020-09-24 7:48 ` Kent Gibson
2020-09-25 9:43 ` Andy Shevchenko
2020-09-22 2:31 ` [PATCH v9 13/20] gpio: uapi: document uAPI v1 as deprecated Kent Gibson
2020-09-22 7:49 ` Arnd Bergmann
2020-09-22 8:11 ` Andy Shevchenko
2020-09-22 9:05 ` Kent Gibson
2020-09-22 2:31 ` [PATCH v9 14/20] tools: gpio: port lsgpio to v2 uAPI Kent Gibson
2020-09-22 2:31 ` [PATCH v9 15/20] tools: gpio: port gpio-watch " Kent Gibson
2020-09-22 2:31 ` [PATCH v9 16/20] tools: gpio: rename nlines to num_lines Kent Gibson
2020-09-22 2:31 ` [PATCH v9 17/20] tools: gpio: port gpio-hammer to v2 uAPI Kent Gibson
2020-09-23 16:30 ` Andy Shevchenko
2020-09-24 7:50 ` Kent Gibson
2020-09-22 2:31 ` [PATCH v9 18/20] tools: gpio: port gpio-event-mon " Kent Gibson
2020-09-22 2:31 ` [PATCH v9 19/20] tools: gpio: add multi-line monitoring to gpio-event-mon Kent Gibson
2020-09-22 2:31 ` [PATCH v9 20/20] tools: gpio: add debounce support " Kent Gibson
2020-09-23 16:35 ` [PATCH v9 00/20] gpio: cdev: add uAPI v2 Andy Shevchenko
2020-09-24 8:00 ` Kent Gibson [this message]
2020-09-25 9:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924080014.GD17562@sol \
--to=warthog618@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).