From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Kent Gibson <warthog618@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v3 05/10] gpio: mockup: use pr_fmt()
Date: Tue, 29 Sep 2020 12:09:59 +0200 [thread overview]
Message-ID: <20200929101004.20288-6-brgl@bgdev.pl> (raw)
In-Reply-To: <20200929101004.20288-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
We don't need a custom logging helper. Let's use the standard pr_fmt()
macro which allows us to use all pr_*() routines with custom format.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpio-mockup.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index 90a1d6c2775f..c2b2f7d5ff34 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -7,6 +7,8 @@
* Copyright (C) 2017 Bartosz Golaszewski <brgl@bgdev.pl>
*/
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
#include <linux/debugfs.h>
#include <linux/gpio/driver.h>
#include <linux/interrupt.h>
@@ -30,8 +32,6 @@
/* Maximum of three properties + the sentinel. */
#define GPIO_MOCKUP_MAX_PROP 4
-#define gpio_mockup_err(...) pr_err(KBUILD_MODNAME ": " __VA_ARGS__)
-
/*
* struct gpio_pin_status - structure describing a GPIO status
* @dir: Configures direction of gpio as "in" or "out"
@@ -548,7 +548,7 @@ static int __init gpio_mockup_init(void)
err = platform_driver_register(&gpio_mockup_driver);
if (err) {
- gpio_mockup_err("error registering platform driver\n");
+ pr_err("error registering platform driver\n");
debugfs_remove_recursive(gpio_mockup_dbg_dir);
return err;
}
@@ -577,7 +577,7 @@ static int __init gpio_mockup_init(void)
pdev = platform_device_register_full(&pdevinfo);
if (IS_ERR(pdev)) {
- gpio_mockup_err("error registering device");
+ pr_err("error registering device");
platform_driver_unregister(&gpio_mockup_driver);
gpio_mockup_unregister_pdevs();
debugfs_remove_recursive(gpio_mockup_dbg_dir);
--
2.26.1
next prev parent reply other threads:[~2020-09-29 10:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 10:09 [PATCH v3 00/10] gpio: mockup: refactoring + documentation Bartosz Golaszewski
2020-09-29 10:09 ` [PATCH v3 01/10] lib: string_helpers: provide kfree_strarray() Bartosz Golaszewski
2020-09-29 10:51 ` Andy Shevchenko
2020-09-29 10:09 ` [PATCH v3 02/10] Documentation: gpio: add documentation for gpio-mockup Bartosz Golaszewski
2020-09-29 10:09 ` [PATCH v3 03/10] gpio: mockup: drop unneeded includes Bartosz Golaszewski
2020-09-29 10:09 ` [PATCH v3 04/10] gpio: mockup: use KBUILD_MODNAME Bartosz Golaszewski
2020-09-29 10:09 ` Bartosz Golaszewski [this message]
2020-09-29 10:10 ` [PATCH v3 06/10] gpio: mockup: remove unneeded return statement Bartosz Golaszewski
2020-09-29 10:10 ` [PATCH v3 07/10] gpio: mockup: increase the number of supported device properties Bartosz Golaszewski
2020-09-29 10:53 ` Andy Shevchenko
2020-09-30 8:05 ` Bartosz Golaszewski
2020-09-29 10:10 ` [PATCH v3 08/10] gpio: mockup: pass the chip label as device property Bartosz Golaszewski
2020-09-29 10:53 ` Andy Shevchenko
2020-09-29 10:10 ` [PATCH v3 09/10] gpio: mockup: use the generic 'gpio-line-names' property Bartosz Golaszewski
2020-09-29 10:10 ` [PATCH v3 10/10] gpio: mockup: refactor the module init function Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929101004.20288-6-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=corbet@lwn.net \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).