* [PATCH v1] gpiolib: Update header block in gpiolib-cdev.h
@ 2020-10-05 9:56 Andy Shevchenko
2020-10-07 9:39 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-10-05 9:56 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, linux-gpio, Kent Gibson
Cc: Andy Shevchenko
The dev_t is defined in types.h while struct gpio_device forward declaration
is missed. Take into account above and update header block in gpiolib-cdev.h.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpiolib-cdev.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-cdev.h b/drivers/gpio/gpiolib-cdev.h
index 973578e7ad10..b42644cbffb8 100644
--- a/drivers/gpio/gpiolib-cdev.h
+++ b/drivers/gpio/gpiolib-cdev.h
@@ -3,7 +3,9 @@
#ifndef GPIOLIB_CDEV_H
#define GPIOLIB_CDEV_H
-#include <linux/device.h>
+#include <linux/types.h>
+
+struct gpio_device;
int gpiolib_cdev_register(struct gpio_device *gdev, dev_t devt);
void gpiolib_cdev_unregister(struct gpio_device *gdev);
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] gpiolib: Update header block in gpiolib-cdev.h
2020-10-05 9:56 [PATCH v1] gpiolib: Update header block in gpiolib-cdev.h Andy Shevchenko
@ 2020-10-07 9:39 ` Linus Walleij
2020-10-07 9:43 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2020-10-07 9:39 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Bartosz Golaszewski, open list:GPIO SUBSYSTEM, Kent Gibson
On Mon, Oct 5, 2020 at 11:56 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> The dev_t is defined in types.h while struct gpio_device forward declaration
> is missed. Take into account above and update header block in gpiolib-cdev.h.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied with some fuzzing, thanks Andy!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] gpiolib: Update header block in gpiolib-cdev.h
2020-10-07 9:39 ` Linus Walleij
@ 2020-10-07 9:43 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-10-07 9:43 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Bartosz Golaszewski, open list:GPIO SUBSYSTEM, Kent Gibson
On Wed, Oct 7, 2020 at 11:39 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Oct 5, 2020 at 11:56 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> > The dev_t is defined in types.h while struct gpio_device forward declaration
> > is missed. Take into account above and update header block in gpiolib-cdev.h.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Patch applied with some fuzzing, thanks Andy!
I noticed I do not need to fuzz it if I simply apply it to fixes....
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-07 9:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-05 9:56 [PATCH v1] gpiolib: Update header block in gpiolib-cdev.h Andy Shevchenko
2020-10-07 9:39 ` Linus Walleij
2020-10-07 9:43 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).