From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-gpio <linux-gpio@vger.kernel.org>
Subject: Re: [libgpiod][PATCH 0/2] tests: improve wait_multiple coverage
Date: Wed, 14 Oct 2020 16:37:12 +0800 [thread overview]
Message-ID: <20201014083712.GA92960@sol> (raw)
In-Reply-To: <CAMpxmJX0E+awshoBJykp2C1ZOK-oCgSDTE2xmeKKZdYW0m4q8Q@mail.gmail.com>
On Wed, Oct 14, 2020 at 09:50:08AM +0200, Bartosz Golaszewski wrote:
> On Wed, Oct 14, 2020 at 5:48 AM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > A couple of patches for the v2 branch that improve the coverage of the
> > wait_multiple test case.
> >
> > The first creates a mismatch between the chip offsets and bulk offsets
> > to highlight the problem with my initial implementation of
> > gpiod_line_event_wait_bulk() for uAPI v2.
> >
> > The second adds a check on the event.offset field added for uAPI v2.
> >
> > Kent Gibson (2):
> > tests: create mismatch between chip and bulk offsets in wait_multiple
> > tests: add check of event offset to wait_multiple
> >
> > tests/tests-event.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > --
> > 2.28.0
> >
>
> I suppose that, if we don't want to do the backward compatible port
> for now, these can be ignored?
>
It wouldn't hurt to have them either way - in my book it never hurts
to increase test coverage.
Cheers,
Kent.
next prev parent reply other threads:[~2020-10-14 8:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 3:47 [libgpiod][PATCH 0/2] tests: improve wait_multiple coverage Kent Gibson
2020-10-14 3:47 ` [libgpiod][PATCH 1/2] tests: create mismatch between chip and bulk offsets in wait_multiple Kent Gibson
2020-10-14 8:45 ` Bartosz Golaszewski
2020-10-14 3:47 ` [libgpiod][PATCH 2/2] tests: add check of event offset to wait_multiple Kent Gibson
2020-10-14 8:50 ` Bartosz Golaszewski
2020-10-14 13:56 ` Bartosz Golaszewski
2020-10-14 7:50 ` [libgpiod][PATCH 0/2] tests: improve wait_multiple coverage Bartosz Golaszewski
2020-10-14 8:37 ` Kent Gibson [this message]
2020-10-14 8:39 ` Bartosz Golaszewski
2020-10-14 8:46 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014083712.GA92960@sol \
--to=warthog618@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).