From: Serge Semin <fancer.lancer@gmail.com>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Hoan Tran <hoan@os.amperecomputing.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Khuong Dinh <khuong@os.amperecomputing.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Wei Xu <xuwei5@hisilicon.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/8] remove never-used "snps,dw-apb-gpio-port"
Date: Thu, 15 Oct 2020 14:40:22 +0300 [thread overview]
Message-ID: <20201015114022.7ptrl37g5d3lumyw@mobilestation> (raw)
In-Reply-To: <20201015115524.24e3c36b@xhacker.debian>
Hello Jisheng,
Thanks for sending this cleanup and for the work you've done in its framework.
The compatible property is indeed redundant in the DW APB GPIO bindings, because
any sub-node is considered as one of the device port from the set {A,B,C,D} and I
don't see why would we need to be there for anything else. The port index is
initialized by the reg property, which I've just realized lack of a proper
constraints.
Anyway see my comment to the DT binding file. The rest of the series is up to
the corresponding subsystem maintainers.
-Sergey
On Thu, Oct 15, 2020 at 11:55:24AM +0800, Jisheng Zhang wrote:
> The "snps,dw-apb-gpio-port" is never used.
>
> Jisheng Zhang (8):
> ARM: dts: berlin: Remove compatible string from dw apb gpio port
> ARM: dts: socfpga: Remove compatible string from dw apb gpio port
> arm64: dts: apm: remove compatible string from dw apb gpio port
> arm64: dts: bitmain: Remove compatible string from dw apb gpio port
> arm64: dts: hip05: Remove compatible string from dw apb gpio port
> arm: dts: socfpga: Remove compatible string from dw apb gpio port
> arm64: dts: synaptics: Remove compatible string from dw apb gpio port
> dt-bindings: gpio: dw-apb: remove never-used "snps,dw-apb-gpio-port"
>
> .../devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 5 -----
> arch/arm/boot/dts/berlin2.dtsi | 6 ------
> arch/arm/boot/dts/berlin2cd.dtsi | 6 ------
> arch/arm/boot/dts/berlin2q.dtsi | 6 ------
> arch/arm/boot/dts/socfpga.dtsi | 3 ---
> arch/arm/boot/dts/socfpga_arria10.dtsi | 3 ---
> arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 --
> arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1 -
> arch/arm64/boot/dts/apm/apm-storm.dtsi | 1 -
> arch/arm64/boot/dts/bitmain/bm1880.dtsi | 3 ---
> arch/arm64/boot/dts/hisilicon/hip05.dtsi | 2 --
> arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 2 --
> arch/arm64/boot/dts/synaptics/as370.dtsi | 2 --
> arch/arm64/boot/dts/synaptics/berlin4ct.dtsi | 6 ------
> 14 files changed, 48 deletions(-)
>
> --
> 2.28.0
>
prev parent reply other threads:[~2020-10-15 11:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 3:55 [PATCH 0/8] remove never-used "snps,dw-apb-gpio-port" Jisheng Zhang
2020-10-15 3:56 ` [PATCH 1/8] ARM: dts: berlin: Remove compatible string from dw apb gpio port Jisheng Zhang
2020-10-15 3:56 ` [PATCH 2/8] ARM: dts: socfpga: " Jisheng Zhang
2020-10-15 3:56 ` [PATCH 3/8] arm64: dts: apm: remove " Jisheng Zhang
2020-10-15 3:57 ` [PATCH 4/8] arm64: dts: bitmain: Remove " Jisheng Zhang
2020-10-15 3:57 ` [PATCH 5/8] arm64: dts: hip05: " Jisheng Zhang
2020-10-15 3:58 ` [PATCH 6/8] arm: dts: socfpga: " Jisheng Zhang
2020-10-15 3:58 ` [PATCH 7/8] arm64: dts: synaptics: " Jisheng Zhang
2020-10-15 3:59 ` [PATCH 8/8] dt-bindings: gpio: dw-apb: remove never-used "snps,dw-apb-gpio-port" Jisheng Zhang
2020-10-15 12:04 ` Serge Semin
2020-10-16 14:43 ` Andy Shevchenko
2020-10-16 16:24 ` Serge Semin
2020-10-15 11:40 ` Serge Semin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015114022.7ptrl37g5d3lumyw@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=hoan@os.amperecomputing.com \
--cc=khuong@os.amperecomputing.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).