linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Helmut Grohne <helmut.grohne@intenta.de>
To: <linux-gpio@vger.kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Subject: Why is the /dev/gpiochip line event kfifo so small?
Date: Wed, 21 Oct 2020 11:09:40 +0200	[thread overview]
Message-ID: <20201021090938.GA13202@laureti-dev> (raw)

Hi,

I was looking into using the /dev/gpiochip API to detect pulses. In my
application, the crucial bit is to precisely identify the start time of
the pule and the API mostly helps doing that by providing high precision
kernel timestamps. However, it stuffs them into a kfifo with 16 entries.
When your hardware is not properly debounced (which it always should,
but often isn't), that space can fill quickly. Is there a reason to
limit the API to such a small number of events?

A single event is 16 bytes. So for every line, we incur 256 bytes of
kfifo space. This space is only incurred for lines that are actually
being watched. It seems to me that bumping up this size would not hurt
badly. Non-realtime applications could then read events after-the-fact
with a smaller risk of missing ones. I've encountered a full kfifo a
number of times now.

Helmut

             reply	other threads:[~2020-10-21  9:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21  9:09 Helmut Grohne [this message]
2020-10-21 11:27 ` Why is the /dev/gpiochip line event kfifo so small? Kent Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201021090938.GA13202@laureti-dev \
    --to=helmut.grohne@intenta.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).