From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH 4/7] gpio: exar: use a helper variable for &pdev->dev
Date: Mon, 26 Oct 2020 15:18:36 +0100 [thread overview]
Message-ID: <20201026141839.28536-5-brgl@bgdev.pl> (raw)
In-Reply-To: <20201026141839.28536-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
It's more elegant to use a helper local variable to store the address
of the underlying struct device than to dereference pdev everywhere. It
also has the benefit of avoiding unnecessary line breaks.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/gpio/gpio-exar.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c
index 752e8437ff80..db366d85b6b4 100644
--- a/drivers/gpio/gpio-exar.c
+++ b/drivers/gpio/gpio-exar.c
@@ -120,7 +120,8 @@ static int exar_direction_input(struct gpio_chip *chip, unsigned int offset)
static int gpio_exar_probe(struct platform_device *pdev)
{
- struct pci_dev *pcidev = to_pci_dev(pdev->dev.parent);
+ struct device *dev = &pdev->dev;
+ struct pci_dev *pcidev = to_pci_dev(dev->parent);
struct exar_gpio_chip *exar_gpio;
u32 first_pin, ngpios;
void __iomem *p;
@@ -134,16 +135,15 @@ static int gpio_exar_probe(struct platform_device *pdev)
if (!p)
return -ENOMEM;
- ret = device_property_read_u32(&pdev->dev, "exar,first-pin",
- &first_pin);
+ ret = device_property_read_u32(dev, "exar,first-pin", &first_pin);
if (ret)
return ret;
- ret = device_property_read_u32(&pdev->dev, "ngpios", &ngpios);
+ ret = device_property_read_u32(dev, "ngpios", &ngpios);
if (ret)
return ret;
- exar_gpio = devm_kzalloc(&pdev->dev, sizeof(*exar_gpio), GFP_KERNEL);
+ exar_gpio = devm_kzalloc(dev, sizeof(*exar_gpio), GFP_KERNEL);
if (!exar_gpio)
return -ENOMEM;
@@ -157,7 +157,7 @@ static int gpio_exar_probe(struct platform_device *pdev)
sprintf(exar_gpio->name, "exar_gpio%d", index);
exar_gpio->gpio_chip.label = exar_gpio->name;
- exar_gpio->gpio_chip.parent = &pdev->dev;
+ exar_gpio->gpio_chip.parent = dev;
exar_gpio->gpio_chip.direction_output = exar_direction_output;
exar_gpio->gpio_chip.direction_input = exar_direction_input;
exar_gpio->gpio_chip.get_direction = exar_get_direction;
@@ -169,8 +169,7 @@ static int gpio_exar_probe(struct platform_device *pdev)
exar_gpio->index = index;
exar_gpio->first_pin = first_pin;
- ret = devm_gpiochip_add_data(&pdev->dev,
- &exar_gpio->gpio_chip, exar_gpio);
+ ret = devm_gpiochip_add_data(dev, &exar_gpio->gpio_chip, exar_gpio);
if (ret)
goto err_destroy;
--
2.29.1
next prev parent reply other threads:[~2020-10-26 14:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 14:18 [PATCH 0/7] gpio: exar: refactor the driver Bartosz Golaszewski
2020-10-26 14:18 ` [PATCH 1/7] gpio: exar: add a newline after the copyright notice Bartosz Golaszewski
2020-10-26 14:18 ` [PATCH 2/7] gpio: exar: include idr.h Bartosz Golaszewski
2020-10-26 14:18 ` [PATCH 3/7] gpio: exar: switch to a simpler IDA interface Bartosz Golaszewski
2020-10-26 14:18 ` Bartosz Golaszewski [this message]
2020-10-26 14:18 ` [RFT PATCH 5/7] gpio: exar: unduplicate address and offset computation Bartosz Golaszewski
2020-10-26 14:52 ` Andy Shevchenko
2020-11-02 10:16 ` Bartosz Golaszewski
2020-11-02 10:58 ` Andy Shevchenko
2020-11-02 11:27 ` David Laight
2020-10-26 14:18 ` [RFT PATCH 6/7] gpio: exar: switch to using regmap Bartosz Golaszewski
2020-10-26 14:59 ` Andy Shevchenko
2020-11-04 16:32 ` Bartosz Golaszewski
2020-10-26 14:18 ` [PATCH 7/7] gpio: exar: use devm action for freeing the IDA and drop remove() Bartosz Golaszewski
2020-10-26 15:03 ` Andy Shevchenko
2020-10-26 15:12 ` Bartosz Golaszewski
2020-10-26 14:46 ` [PATCH 0/7] gpio: exar: refactor the driver Andy Shevchenko
2020-10-26 15:05 ` Andy Shevchenko
2020-10-27 15:12 ` Jan Kiszka
2020-11-04 13:57 ` Jan Kiszka
2020-11-04 14:52 ` Andy Shevchenko
2020-11-04 16:23 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026141839.28536-5-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).