From: Arnaud de Turckheim <quarium@gmail.com>
To: linus.walleij@linaro.org
Cc: bgolaszewski@baylibre.com, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, vilhelm.gray@gmail.com,
Arnaud de Turckheim <quarium@gmail.com>
Subject: [PATCH 0/3] gpio: pcie-idio-24: Fix IRQ handling
Date: Wed, 4 Nov 2020 16:24:52 +0100 [thread overview]
Message-ID: <20201104152455.40627-1-quarium@gmail.com> (raw)
This patch set fixes the irq_mask/irq_unmask functions and enables the
PLX PEX8311 local interrupts.
With the current version of the driver, gpiomon (from libgpiod) or a
poll(2) on the sysfs value are not working. According to
/proc/interrupts, there is no interruption triggered.
The main issue is that the local interrupts are not forwarded by the
PEX8311 to the PCI.
There is also two bugs:
- The IRQ mask is not correctly updated when unmasking an
interruption.
- The COS Enable Register value is not correctly updated when
masking/unmasking an interruption.
It seems this problems exist since the initial commit.
Arnaud de Turckheim (3):
gpio: pcie-idio-24: Fix irq mask when masking
gpio: pcie-idio-24: Fix IRQ Enable Register value
gpio: pcie-idio-24: Enable PEX8311 interrupts
drivers/gpio/gpio-pcie-idio-24.c | 62 ++++++++++++++++++++++++++++----
1 file changed, 56 insertions(+), 6 deletions(-)
--
2.25.1
next reply other threads:[~2020-11-04 15:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 15:24 Arnaud de Turckheim [this message]
2020-11-04 15:24 ` [PATCH 1/3] gpio: pcie-idio-24: Fix irq mask when masking Arnaud de Turckheim
2020-11-04 15:47 ` William Breathitt Gray
2020-11-04 15:24 ` [PATCH 2/3] gpio: pcie-idio-24: Fix IRQ Enable Register value Arnaud de Turckheim
2020-11-04 15:47 ` William Breathitt Gray
2020-11-04 15:24 ` [PATCH 3/3] gpio: pcie-idio-24: Enable PEX8311 interrupts Arnaud de Turckheim
2020-11-04 15:47 ` William Breathitt Gray
2020-11-04 15:45 ` [PATCH 0/3] gpio: pcie-idio-24: Fix IRQ handling William Breathitt Gray
2020-11-06 14:20 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104152455.40627-1-quarium@gmail.com \
--to=quarium@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).