From: Arnaud de Turckheim <quarium@gmail.com>
To: linus.walleij@linaro.org
Cc: bgolaszewski@baylibre.com, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, vilhelm.gray@gmail.com,
Arnaud de Turckheim <quarium@gmail.com>
Subject: [PATCH 1/3] gpio: pcie-idio-24: Fix irq mask when masking
Date: Wed, 4 Nov 2020 16:24:53 +0100 [thread overview]
Message-ID: <20201104152455.40627-2-quarium@gmail.com> (raw)
In-Reply-To: <20201104152455.40627-1-quarium@gmail.com>
Fix the bitwise operation to remove only the corresponding bit from the
mask.
Fixes: 585562046628 ("gpio: Add GPIO support for the ACCES PCIe-IDIO-24 family")
Signed-off-by: Arnaud de Turckheim <quarium@gmail.com>
---
drivers/gpio/gpio-pcie-idio-24.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-pcie-idio-24.c b/drivers/gpio/gpio-pcie-idio-24.c
index a68941d19ac6..5ea517416366 100644
--- a/drivers/gpio/gpio-pcie-idio-24.c
+++ b/drivers/gpio/gpio-pcie-idio-24.c
@@ -339,7 +339,7 @@ static void idio_24_irq_mask(struct irq_data *data)
raw_spin_lock_irqsave(&idio24gpio->lock, flags);
- idio24gpio->irq_mask &= BIT(bit_offset);
+ idio24gpio->irq_mask &= ~BIT(bit_offset);
new_irq_mask = idio24gpio->irq_mask >> bank_offset;
if (!new_irq_mask) {
--
2.25.1
next prev parent reply other threads:[~2020-11-04 15:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 15:24 [PATCH 0/3] gpio: pcie-idio-24: Fix IRQ handling Arnaud de Turckheim
2020-11-04 15:24 ` Arnaud de Turckheim [this message]
2020-11-04 15:47 ` [PATCH 1/3] gpio: pcie-idio-24: Fix irq mask when masking William Breathitt Gray
2020-11-04 15:24 ` [PATCH 2/3] gpio: pcie-idio-24: Fix IRQ Enable Register value Arnaud de Turckheim
2020-11-04 15:47 ` William Breathitt Gray
2020-11-04 15:24 ` [PATCH 3/3] gpio: pcie-idio-24: Enable PEX8311 interrupts Arnaud de Turckheim
2020-11-04 15:47 ` William Breathitt Gray
2020-11-04 15:45 ` [PATCH 0/3] gpio: pcie-idio-24: Fix IRQ handling William Breathitt Gray
2020-11-06 14:20 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104152455.40627-2-quarium@gmail.com \
--to=quarium@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).