From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9C96C55ABD for ; Tue, 10 Nov 2020 12:33:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9770820781 for ; Tue, 10 Nov 2020 12:33:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="faspQ8Bz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730188AbgKJMdu (ORCPT ); Tue, 10 Nov 2020 07:33:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730099AbgKJMdt (ORCPT ); Tue, 10 Nov 2020 07:33:49 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C185DC0613D1 for ; Tue, 10 Nov 2020 04:33:48 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id 33so12474048wrl.7 for ; Tue, 10 Nov 2020 04:33:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=adL3l4Z6O1Wj+nFN/YxWHj+awQmL8BIw4xUsIWOJIFU=; b=faspQ8BzRWWLawQEXCxcNlRzXA70LzQ/kyT7u9kukuF/Vpiwo8YKS2m8B0ImHXd7V5 3mbcXAk5tx5LRwOv55zrqFJs2elynUqtHwLdzkYhUhdldyGbn/+uCHUOdYgsueHgTUDL Uj4oP3yVWFXDe6rSizQKSrbRhKSH4d2+lVrMPlekPu3FkeV6v1ttK2KPaXv09c5o/qeT eMxYBFeCj/XrF2AGbHShK3MHDIBMARGYESjMKvYJIDA5ayOD8RZCe+pY2p1d3c6qEM/Z /thwSPnBl/GjtI4zT+HOq3q+127EJr7BNM8snvIn0WBppyQ4HAbolnk+M7l3gTXsBwQi 0iXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=adL3l4Z6O1Wj+nFN/YxWHj+awQmL8BIw4xUsIWOJIFU=; b=fipxLgVWjuNGrkYd8Q1tOyFo5lj3JgoJw/6Z19h4IF6sjA/rV0yulbcpY3kOAhQEZq wIsy4xa4s6YiVX2+a3R0xIiB0xNFd73ooM5M+E1kKTv5BXOkCPFNwYYTrwvj2niTsjKX qBTkcL/eMq2qzFufhbQR0PeDu5FaXIII5qOW/MWZHoCshcgZCtX9FP9xcQWliK46VPJz f8/RVI0Vhqi0fM93loXGbXKzXquaYeVQy3eSS+Jfxl9p5oJSBqTLeCZsji2gVKBNowjU LR7wqjEYFChoy/LqlIFuo+RjoLqa4QhcJIHsqVgu585B9ABSDITz1tFncfRrdrFpNgcZ IAbw== X-Gm-Message-State: AOAM533zAUcy+xd+kYdeqX7LOrlfaYLFodBmwalg3ICR3ZuhZM42SgNK RV6vpRvsEs1xQZ2H9ivXsWM6rA== X-Google-Smtp-Source: ABdhPJxZPply2n7CRqXgJ77F5nNnXHOb82wOg3adEzxhKYvTXvrxBXsFjrE/106amH39DfhVLRZQfA== X-Received: by 2002:adf:e446:: with SMTP id t6mr22566685wrm.46.1605011627448; Tue, 10 Nov 2020 04:33:47 -0800 (PST) Received: from debian-brgl.home (amarseille-656-1-4-167.w90-8.abo.wanadoo.fr. [90.8.158.167]) by smtp.gmail.com with ESMTPSA id f8sm16706837wrt.88.2020.11.10.04.33.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 04:33:46 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Andy Shevchenko , Jan Kiszka , David Laight , Mark Brown Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v3 0/7] gpio: exar: refactor the driver Date: Tue, 10 Nov 2020 13:33:35 +0100 Message-Id: <20201110123342.3166-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.29.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Bartosz Golaszewski I just wanted to convert the driver to using simpler IDA API but ended up quickly converting it to using regmap. Unfortunately I don't have the HW to test it so marking the patches that introduce functional change as RFT and Cc'ing the original author. v1 -> v2: - add new regmap helper: regmap_assign_bits() - fix lvl vs sel register access - set value in direction_output callback v2 -> v3: - drop the regmap helper from series Note: I didn't use the fancy method of offset calculation Andy and David suggested because this series broke the driver according to Jan - let's get it right before we modify it any more. I found a couple problems that could maybe cause the crash. Jan: could you give it another spin? Bartosz Golaszewski (7): gpio: exar: add a newline after the copyright notice gpio: exar: include idr.h gpio: exar: switch to a simpler IDA interface gpio: exar: use a helper variable for &pdev->dev gpio: exar: unduplicate address and offset computation gpio: exar: switch to using regmap gpio: exar: use devm action for freeing the IDA and drop remove() drivers/gpio/Kconfig | 1 + drivers/gpio/gpio-exar.c | 154 +++++++++++++++++++-------------------- 2 files changed, 77 insertions(+), 78 deletions(-) -- 2.29.1