From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-gpio@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v5 04/17] gpiolib: Add temporary variable to gpiod_set_transitory() for cleaner code
Date: Wed, 11 Nov 2020 17:32:31 +0200 [thread overview]
Message-ID: <20201111153231.GA2495@lahna.fi.intel.com> (raw)
In-Reply-To: <20201109205332.19592-5-andriy.shevchenko@linux.intel.com>
On Mon, Nov 09, 2020 at 10:53:19PM +0200, Andy Shevchenko wrote:
> Temporary variable that keeps mode allows to neat the code a bit.
> It will also help for the future changes.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Not really sure if this is good change or not. Instead of constant you
now introduce a useless variable just to get them to the same line.
To me this looks better and reads easier:
packed = pinconf_to_config_packed(PIN_CONFIG_PERSIST_STATE, !transitory);
But not insisting so if GPIO maintainers are fine then no objections :)
next prev parent reply other threads:[~2020-11-11 15:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 20:53 [PATCH v5 00/17] gpiolib: acpi: pin configuration fixes Andy Shevchenko
2020-11-09 20:53 ` [PATCH v5 01/17] gpiolib: Replace unsigned by unsigned int Andy Shevchenko
2020-11-11 15:17 ` Mika Westerberg
2020-11-09 20:53 ` [PATCH v5 02/17] gpiolib: add missed break statement Andy Shevchenko
2020-11-11 15:18 ` Mika Westerberg
2020-11-09 20:53 ` [PATCH v5 03/17] gpiolib: use proper API to pack pin configuration parameters Andy Shevchenko
2020-11-11 15:23 ` Mika Westerberg
2020-11-09 20:53 ` [PATCH v5 04/17] gpiolib: Add temporary variable to gpiod_set_transitory() for cleaner code Andy Shevchenko
2020-11-11 15:32 ` Mika Westerberg [this message]
2020-11-11 15:40 ` Andy Shevchenko
2020-11-11 19:24 ` Andy Shevchenko
2020-11-09 20:53 ` [PATCH v5 05/17] gpiolib: Extract gpio_set_config_with_argument() for future use Andy Shevchenko
2020-11-11 15:33 ` Mika Westerberg
2020-11-09 20:53 ` [PATCH v5 06/17] gpiolib: move bias related code from gpio_set_config() to gpio_set_bias() Andy Shevchenko
2020-11-11 15:33 ` Mika Westerberg
2020-11-09 20:53 ` [PATCH v5 07/17] gpiolib: Extract gpio_set_config_with_argument_optional() helper Andy Shevchenko
2020-11-11 15:35 ` Mika Westerberg
2020-11-11 15:42 ` Andy Shevchenko
2020-11-09 20:53 ` [PATCH v5 08/17] gpiolib: Extract gpio_set_debounce_timeout() for internal use Andy Shevchenko
2020-11-11 15:39 ` Mika Westerberg
2020-11-11 15:46 ` Andy Shevchenko
2020-11-11 15:52 ` Mika Westerberg
2020-11-11 16:15 ` Andy Shevchenko
2020-11-09 20:53 ` [PATCH v5 09/17] gpiolib: acpi: Respect bias settings for GpioInt() resource Andy Shevchenko
2020-11-09 20:53 ` [PATCH v5 10/17] gpiolib: acpi: Use named item for enum gpiod_flags variable Andy Shevchenko
2020-11-09 20:53 ` [PATCH v5 11/17] gpiolib: acpi: Take into account debounce settings Andy Shevchenko
2020-11-11 15:41 ` Mika Westerberg
2020-11-09 20:53 ` [PATCH v5 12/17] gpiolib: acpi: Move acpi_gpio_to_gpiod_flags() upper in the code Andy Shevchenko
2020-11-11 15:49 ` Mika Westerberg
2020-11-09 20:53 ` [PATCH v5 13/17] gpiolib: acpi: Make acpi_gpio_to_gpiod_flags() usable for GpioInt() Andy Shevchenko
2020-11-11 15:50 ` Mika Westerberg
2020-11-09 20:53 ` [PATCH v5 14/17] gpiolib: acpi: Extract acpi_request_own_gpiod() helper Andy Shevchenko
2020-11-11 15:51 ` Mika Westerberg
2020-11-09 20:53 ` [PATCH v5 15/17] gpiolib: acpi: Convert pin_index to be u16 Andy Shevchenko
2020-11-11 15:55 ` Mika Westerberg
2020-11-09 20:53 ` [PATCH v5 16/17] gpiolib: acpi: Use BIT() macro to increase readability Andy Shevchenko
2020-11-11 15:57 ` Mika Westerberg
2020-11-11 17:01 ` Andy Shevchenko
2020-11-09 20:53 ` [PATCH v5 17/17] gpiolib: acpi: Make Intel GPIO tree official for GPIO ACPI work Andy Shevchenko
2020-11-11 19:27 ` Andy Shevchenko
2020-11-12 7:00 ` Mika Westerberg
2020-11-17 20:48 ` Linus Walleij
2020-11-10 14:08 ` [PATCH v5 00/17] gpiolib: acpi: pin configuration fixes Hans de Goede
2020-11-10 14:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111153231.GA2495@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).