* [PATCH v1] pinctrl: jasperlake: Fix HOSTSW_OWN register offset
@ 2020-11-11 21:54 Andy Shevchenko
2020-11-11 22:07 ` Evan Green
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-11-11 21:54 UTC (permalink / raw)
To: Linus Walleij, Mika Westerberg, linux-gpio; +Cc: Andy Shevchenko, Evan Green
Jasper Lake uses different offset for HOSTSW_OWN register.
Fix it here.
Fixes: e278dcb7048b ("pinctrl: intel: Add Intel Jasper Lake pin controller support")
Reported-by: Evan Green <evgreen@chromium.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
I have got a confirmation that PADCFGLOCK is still 0x80.
I updated my patch and put your name as Reported-by. If you want me
to have your patch instead, I can review it (it needs some massage
of the commit message)
drivers/pinctrl/intel/pinctrl-jasperlake.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/pinctrl-jasperlake.c b/drivers/pinctrl/intel/pinctrl-jasperlake.c
index c5e204c8da9c..ec435b7ab392 100644
--- a/drivers/pinctrl/intel/pinctrl-jasperlake.c
+++ b/drivers/pinctrl/intel/pinctrl-jasperlake.c
@@ -16,7 +16,7 @@
#define JSL_PAD_OWN 0x020
#define JSL_PADCFGLOCK 0x080
-#define JSL_HOSTSW_OWN 0x0b0
+#define JSL_HOSTSW_OWN 0x0c0
#define JSL_GPI_IS 0x100
#define JSL_GPI_IE 0x120
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] pinctrl: jasperlake: Fix HOSTSW_OWN register offset
2020-11-11 21:54 [PATCH v1] pinctrl: jasperlake: Fix HOSTSW_OWN register offset Andy Shevchenko
@ 2020-11-11 22:07 ` Evan Green
2020-11-11 22:15 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Evan Green @ 2020-11-11 22:07 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Linus Walleij, Mika Westerberg, linux-gpio
On Wed, Nov 11, 2020 at 1:54 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Jasper Lake uses different offset for HOSTSW_OWN register.
> Fix it here.
>
> Fixes: e278dcb7048b ("pinctrl: intel: Add Intel Jasper Lake pin controller support")
> Reported-by: Evan Green <evgreen@chromium.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> I have got a confirmation that PADCFGLOCK is still 0x80.
> I updated my patch and put your name as Reported-by. If you want me
> to have your patch instead, I can review it (it needs some massage
> of the commit message)
Either way is ok. I'm happy to spin and edit my commit message, let me
know how to change.
-Evan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] pinctrl: jasperlake: Fix HOSTSW_OWN register offset
2020-11-11 22:07 ` Evan Green
@ 2020-11-11 22:15 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-11-11 22:15 UTC (permalink / raw)
To: Evan Green
Cc: Andy Shevchenko, Linus Walleij, Mika Westerberg,
open list:GPIO SUBSYSTEM
On Thu, Nov 12, 2020 at 12:08 AM Evan Green <evgreen@chromium.org> wrote:
>
> On Wed, Nov 11, 2020 at 1:54 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Jasper Lake uses different offset for HOSTSW_OWN register.
> > Fix it here.
> >
> > Fixes: e278dcb7048b ("pinctrl: intel: Add Intel Jasper Lake pin controller support")
> > Reported-by: Evan Green <evgreen@chromium.org>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > I have got a confirmation that PADCFGLOCK is still 0x80.
> > I updated my patch and put your name as Reported-by. If you want me
> > to have your patch instead, I can review it (it needs some massage
> > of the commit message)
>
> Either way is ok. I'm happy to spin and edit my commit message, let me
> know how to change.
Okay, let's drop this one, because it repeats yours 100% code wise.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-11 22:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-11 21:54 [PATCH v1] pinctrl: jasperlake: Fix HOSTSW_OWN register offset Andy Shevchenko
2020-11-11 22:07 ` Evan Green
2020-11-11 22:15 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox