From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/2] pinctrl: lynxpoint: Use defined constant for disabled bias explicitly
Date: Thu, 12 Nov 2020 10:00:12 +0200 [thread overview]
Message-ID: <20201112080012.GR2495@lahna.fi.intel.com> (raw)
In-Reply-To: <20201111113432.35641-1-andriy.shevchenko@linux.intel.com>
On Wed, Nov 11, 2020 at 01:34:31PM +0200, Andy Shevchenko wrote:
> We have a specific constant to describe a disabled bias,
> i.e. GPIWP_NONE. Use it explicitly instead of making
> an assumption about its value.
>
> While at it, move argument assignment to the switch-case
> in lp_pin_config_get().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
prev parent reply other threads:[~2020-11-12 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 11:34 [PATCH v1 1/2] pinctrl: lynxpoint: Use defined constant for disabled bias explicitly Andy Shevchenko
2020-11-11 11:34 ` [PATCH v1 2/2] pinctrl: lynxpoint: Enable pin configuration setting for GPIO chip Andy Shevchenko
2020-11-12 8:00 ` Mika Westerberg
2020-11-12 11:00 ` Andy Shevchenko
2020-11-12 8:00 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112080012.GR2495@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).