From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-gpio@vger.kernel.org,
Vasile-Laurentiu Stanimir
<vasile-laurentiu.stanimir@windriver.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v7 13/18] gpiolib: acpi: Set initial value for output pin based on bias and polarity
Date: Thu, 12 Nov 2020 11:10:16 +0200 [thread overview]
Message-ID: <20201112091016.GY2495@lahna.fi.intel.com> (raw)
In-Reply-To: <20201111222008.39993-14-andriy.shevchenko@linux.intel.com>
On Thu, Nov 12, 2020 at 12:20:03AM +0200, Andy Shevchenko wrote:
> From: Vasile-Laurentiu Stanimir <vasile-laurentiu.stanimir@windriver.com>
>
> GpioIo() resources don't contain an initial value for the output pin.
> Therefore instead of deducting its value solely based on bias field
> we should deduce that value from the polarity and the bias fields.
> Typical scenario is, when pin is defined in the table and its polarity,
> specified in _DSD or via platform code, is defined as active low,
> in the following call chain:
>
> -> acpi_populate_gpio_lookup()
> -> acpi_gpio_to_gpiod_flags()
>
> it will return GPIOD_OUT_HIGH if bias is set no matter if polarity
> is GPIO_ACTIVE_LOW, so it will return the current level instead of
> the logical level.
>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2020-11-12 9:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 22:19 [PATCH v7 00/18] gpiolib: acpi: pin configuration fixes Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 01/18] gpiolib: Replace unsigned by unsigned int Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 02/18] gpiolib: add missed break statement Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 03/18] gpiolib: use proper API to pack pin configuration parameters Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 04/18] gpiolib: Extract gpio_set_config_with_argument() for future use Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 05/18] gpiolib: move bias related code from gpio_set_config() to gpio_set_bias() Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 06/18] gpiolib: Extract gpio_set_config_with_argument_optional() helper Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 07/18] gpiolib: Introduce gpio_set_debounce_timeout() for internal use Andy Shevchenko
2020-11-12 8:16 ` Mika Westerberg
2020-11-12 10:19 ` Andy Shevchenko
2020-11-12 11:06 ` Mika Westerberg
2020-11-12 11:12 ` Hans de Goede
2020-11-12 12:08 ` Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 08/18] gpiolib: acpi: Respect bias settings for GpioInt() resource Andy Shevchenko
2020-11-11 22:19 ` [PATCH v7 09/18] gpiolib: acpi: Use named item for enum gpiod_flags variable Andy Shevchenko
2020-11-11 22:20 ` [PATCH v7 10/18] gpiolib: acpi: Take into account debounce settings Andy Shevchenko
2020-11-11 22:20 ` [PATCH v7 11/18] gpiolib: acpi: Move non-critical code outside of critical section Andy Shevchenko
2020-11-12 8:17 ` Mika Westerberg
2020-11-11 22:20 ` [PATCH v7 12/18] gpiolib: acpi: Move acpi_gpio_to_gpiod_flags() upper in the code Andy Shevchenko
2020-11-11 22:20 ` [PATCH v7 13/18] gpiolib: acpi: Set initial value for output pin based on bias and polarity Andy Shevchenko
2020-11-12 9:10 ` Mika Westerberg [this message]
2020-11-11 22:20 ` [PATCH v7 14/18] gpiolib: acpi: Make acpi_gpio_to_gpiod_flags() usable for GpioInt() Andy Shevchenko
2020-11-11 22:20 ` [PATCH v7 15/18] gpiolib: acpi: Extract acpi_request_own_gpiod() helper Andy Shevchenko
2020-11-11 22:20 ` [PATCH v7 16/18] gpiolib: acpi: Convert pin_index to be u16 Andy Shevchenko
2020-11-11 22:20 ` [PATCH v7 17/18] gpiolib: acpi: Use BIT() macro to increase readability Andy Shevchenko
2020-11-11 22:20 ` [PATCH v7 18/18] gpiolib: acpi: Make Intel GPIO tree official for GPIO ACPI work Andy Shevchenko
2020-11-12 10:24 ` [PATCH v7 00/18] gpiolib: acpi: pin configuration fixes Andy Shevchenko
2020-11-12 14:16 ` Andy Shevchenko
2020-11-15 16:04 ` Linus Walleij
2020-11-16 9:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112091016.GY2495@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=vasile-laurentiu.stanimir@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).