From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1] pinctrl: merrifield: Set default bias in case no particular value given
Date: Thu, 12 Nov 2020 15:59:16 +0200 [thread overview]
Message-ID: <20201112135916.GF4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201112080650.GU2495@lahna.fi.intel.com>
On Thu, Nov 12, 2020 at 10:06:50AM +0200, Mika Westerberg wrote:
> On Wed, Nov 11, 2020 at 02:06:05PM +0200, Andy Shevchenko wrote:
> > When GPIO library asks pin control to set the bias, it doesn't pass
> > any value of it and argument is considered boolean (and this is true
> > for ACPI GpioIo() / GpioInt() resources, by the way). Thus, individual
> > drivers must behave well, when they got the resistance value of 1 Ohm,
> > i.e. transforming it to sane default.
> >
> > In case of Intel Merrifield pin control hardware the 20 kOhm sounds plausible
> > because it gives a good trade off between weakness and minimization of leakage
> > current (will be only 50 uA with the above choice).
> >
> > Fixes: 4e80c8f50574 ("pinctrl: intel: Add Intel Merrifield pin controller support")
> > Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-11-12 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 12:06 [PATCH v1] pinctrl: merrifield: Set default bias in case no particular value given Andy Shevchenko
2020-11-12 8:06 ` Mika Westerberg
2020-11-12 13:59 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112135916.GF4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).