Re: [PATCH 2/2] RFT: gpio: tegra186: Set affinity callback to parent

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1987 bytes --]

On Wed, Nov 11, 2020 at 03:06:28PM +0100, Linus Walleij wrote:
> This assigns the .irq_set_affinity to the parent callback.
> I assume the Tegra186 is an SMP system so this would be
> beneficial.
> 
> I used the pattern making the hirerarchy tolerant for missing
> parent as in Marc's earlier patch.
> 
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Vidya Sagar <vidyas@nvidia.com>
> Suggested-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/gpio/gpio-tegra186.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c
> index 9500074b1f1b..5060e81f5f49 100644
> --- a/drivers/gpio/gpio-tegra186.c
> +++ b/drivers/gpio/gpio-tegra186.c
> @@ -444,6 +444,16 @@ static int tegra186_irq_set_wake(struct irq_data *data, unsigned int on)
>  	return 0;
>  }
>  
> +static int tegra186_irq_set_affinity(struct irq_data *data,
> +				     const struct cpumask *dest,
> +				     bool force)
> +{
> +	if (data->parent_data)
> +		return irq_chip_set_affinity_parent(data, dest, force);
> +
> +	return 0;
> +}
> +
>  static void tegra186_gpio_irq(struct irq_desc *desc)
>  {
>  	struct tegra_gpio *gpio = irq_desc_get_handler_data(desc);
> @@ -690,6 +700,7 @@ static int tegra186_gpio_probe(struct platform_device *pdev)
>  	gpio->intc.irq_unmask = tegra186_irq_unmask;
>  	gpio->intc.irq_set_type = tegra186_irq_set_type;
>  	gpio->intc.irq_set_wake = tegra186_irq_set_wake;
> +	gpio->intc.irq_set_affinity = tegra186_irq_set_affinity;
>  
>  	irq = &gpio->gpio.irq;
>  	irq->chip = &gpio->intc;

This does seem to mostly work, but I do get this new warning during
boot:

    [    6.406230] genirq: irq_chip gpio did not update eff. affinity mask of irq 70

Any idea what that's supposed to mean? I can probably dig in some more
early next week to see if I can track down why exactly that happens.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]