From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1] pinctrl: baytrail: Avoid clearing debounce value when turning it off
Date: Mon, 16 Nov 2020 12:04:34 +0200 [thread overview]
Message-ID: <20201116100434.GU4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201113093611.GL2495@lahna.fi.intel.com>
On Fri, Nov 13, 2020 at 11:36:11AM +0200, Mika Westerberg wrote:
> On Thu, Nov 12, 2020 at 09:03:01PM +0200, Andy Shevchenko wrote:
> > Baytrail pin control has a common register to set up debounce timeout.
> > When a pin configuration requested debounce to be disabled, the rest
> > of the pins may still want to have debounce enabled and thus rely on
> > the common timeout value. Avoid clearing debounce value when turning
> > it off for one pin while others may still use it.
> >
> > Fixes: 658b476c742f ("pinctrl: baytrail: Add debounce configuration")
> > Depends-on: 04ff5a095d66 ("pinctrl: baytrail: Rectify debounce support")
> > Depends-on: 827e1579e1d5 ("pinctrl: baytrail: Rectify debounce support (part 2)")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-11-16 10:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 19:03 [PATCH v1] pinctrl: baytrail: Avoid clearing debounce value when turning it off Andy Shevchenko
2020-11-13 9:36 ` Mika Westerberg
2020-11-16 10:04 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116100434.GU4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).