From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
David Laight <David.Laight@aculab.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v5 0/7] gpio: exar: refactor the driver
Date: Mon, 23 Nov 2020 15:37:18 +0200 [thread overview]
Message-ID: <20201123133718.GD4077@smile.fi.intel.com> (raw)
In-Reply-To: <fe36f3f9-fc33-c39a-1b6e-962fe2567bb8@siemens.com>
On Mon, Nov 23, 2020 at 01:57:07PM +0100, Jan Kiszka wrote:
> On 23.11.20 13:12, Bartosz Golaszewski wrote:
> > Thanks!On Mon, Nov 23, 2020 at 1:03 PM Jan Kiszka
> > <jan.kiszka@siemens.com> wrote:
> >>
> >> On 23.11.20 12:38, Bartosz Golaszewski wrote:
> >>> On Mon, Nov 16, 2020 at 11:42 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >>>>
> >>>> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >>>>
> >>>> I just wanted to convert the driver to using simpler IDA API but ended up
> >>>> quickly converting it to using regmap. Unfortunately I don't have the HW
> >>>> to test it so marking the patches that introduce functional change as RFT
> >>>> and Cc'ing the original author.
> >>>>
> >>>
> >>> Hi Jan!
> >>>
> >>> Could you give this last version a final spin before I merge it?
> >>>
> >>
> >> [ 14.250117] exar_serial 0000:02:00.0: enabling device (0000 -> 0002)
> >> [ 14.336622] 0000:02:00.0: ttyS2 at MMIO 0x90000000 (irq = 44, base_baud = 7812500) is a XR17V35X
> >> [ 14.391588] 0000:02:00.0: ttyS3 at MMIO 0x90000400 (irq = 44, base_baud = 7812500) is a XR17V35X
> >> [ 19.250510] gpio_exar: probe of gpio_exar.1.auto failed with error -22
> >>
> >> That's "new"...
> >>
> >
> > And if you change reg_bits from 11 to 16?
> >
>
> 16 works. Didn't we have that already?
Yes, but it puzzles me what the idea behind it and don't we see the regmap
issue here. In any case, I'm fine with 16 there, although it's not clear
to me why 11 is not working...
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-11-23 13:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 10:42 [PATCH v5 0/7] gpio: exar: refactor the driver Bartosz Golaszewski
2020-11-16 10:42 ` [PATCH v5 1/7] gpio: exar: add a newline after the copyright notice Bartosz Golaszewski
2020-11-16 10:42 ` [PATCH v5 2/7] gpio: exar: include idr.h Bartosz Golaszewski
2020-11-16 10:42 ` [PATCH v5 3/7] gpio: exar: switch to a simpler IDA interface Bartosz Golaszewski
2020-11-16 10:42 ` [PATCH v5 4/7] gpio: exar: use a helper variable for &pdev->dev Bartosz Golaszewski
2020-11-16 10:42 ` [PATCH v5 5/7] gpio: exar: unduplicate address and offset computation Bartosz Golaszewski
2020-11-16 10:42 ` [PATCH v5 6/7] gpio: exar: switch to using regmap Bartosz Golaszewski
2020-11-16 10:42 ` [PATCH v5 7/7] gpio: exar: use devm action for freeing the IDA and drop remove() Bartosz Golaszewski
2020-11-23 11:38 ` [PATCH v5 0/7] gpio: exar: refactor the driver Bartosz Golaszewski
2020-11-23 11:58 ` Jan Kiszka
2020-11-23 12:08 ` Jan Kiszka
2020-11-23 12:51 ` Bartosz Golaszewski
2020-11-23 12:12 ` Bartosz Golaszewski
2020-11-23 12:57 ` Jan Kiszka
2020-11-23 13:33 ` Bartosz Golaszewski
2020-11-23 13:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123133718.GD4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=David.Laight@aculab.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=jan.kiszka@siemens.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).