From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: linus.walleij@linaro.org
Cc: robh+dt@kernel.org, gregkh@linuxfoundation.org,
yanaijie@huawei.com, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, devel@driverdev.osuosl.org
Subject: [PATCH 1/8] dt-bindings: pinctrl: rt2880: properly redo bindings
Date: Sun, 13 Dec 2020 17:17:14 +0100 [thread overview]
Message-ID: <20201213161721.6514-2-sergio.paracuellos@gmail.com> (raw)
In-Reply-To: <20201213161721.6514-1-sergio.paracuellos@gmail.com>
When this bindings where applied there weren't already
reviewed and some old hacks was being used to properly
pass the schemas checks. This commits fix them up:
- Instead of using 'if-then' clause use '-pins$'.
- 'groups' and 'function' are included inside a new
'^(.*-)?pinmux$' node.
- compatible string is not an 'enum' but a 'const'.
- 'pinctrl-0' and 'pinctrl-names' removed since they are
used in consumer nodes.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
.../pinctrl/ralink,rt2880-pinmux.yaml | 62 +++++++++----------
1 file changed, 28 insertions(+), 34 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml
index 7dea3e26d99e..b32f2676cab5 100644
--- a/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml
@@ -15,39 +15,38 @@ description:
properties:
compatible:
- enum:
- - ralink,rt2880-pinmux
+ const: ralink,rt2880-pinmux
- pinctrl-0:
- description:
- A phandle to the node containing the subnodes containing default
- configurations. This is for pinctrl hogs.
+patternProperties:
+ '-pins$':
+ type: object
+ patternProperties:
+ '^(.*-)?pinmux$':
+ type: object
+ description: node for pinctrl.
+ $ref: pinmux-node.yaml#
+
+ properties:
+ groups:
+ description: Name of the pin group to use for the functions.
+ enum: [i2c, spi, uart1, uart2, uart3, rgmii1, rgmii2, mdio,
+ pcie, sdhci]
+ function:
+ description: The mux function to select
+ enum: [gpio, i2c, spi, uart1, uart2, uart3, rgmii1, rgmii2,
+ mdio, nand1, nand2, sdhci]
+
+ required:
+ - groups
+ - function
+
+ additionalProperties: false
- pinctrl-names:
- description:
- A pinctrl state named "default" can be defined.
- const: default
+ additionalProperties: false
required:
- compatible
-patternProperties:
- '[a-z0-9_-]+':
- if:
- type: object
- description: node for pinctrl.
- $ref: "pinmux-node.yaml"
- then:
- properties:
- groups:
- description: Name of the pin group to use for the functions.
- enum: [i2c, spi, uart1, uart2, uart3, rgmii1, rgmii2, mdio,
- pcie, sdhci]
- function:
- description: The mux function to select
- enum: [gpio, i2c, spi, uart1, uart2, uart3, rgmii1, rgmii2,
- mdio, nand1, nand2, sdhci]
-
additionalProperties: false
examples:
@@ -55,14 +54,9 @@ examples:
- |
pinctrl {
compatible = "ralink,rt2880-pinmux";
- pinctrl-names = "default";
- pinctrl-0 = <&state_default>;
-
- state_default: pinctrl0 {
- };
- i2c_pins: i2c0 {
- i2c0 {
+ i2c_pins: i2c0-pins {
+ pinmux {
groups = "i2c";
function = "i2c";
};
--
2.25.1
next prev parent reply other threads:[~2020-12-13 16:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 16:17 [PATCH 0/8] pinctrl: ralink: rt2880: Some minimal clean ups Sergio Paracuellos
2020-12-13 16:17 ` Sergio Paracuellos [this message]
2020-12-15 17:02 ` [PATCH 1/8] dt-bindings: pinctrl: rt2880: properly redo bindings Rob Herring
2020-12-13 16:17 ` [PATCH 2/8] pinctrl: ralink: rt2880: avoid double pointer to simplify code Sergio Paracuellos
2020-12-13 16:17 ` [PATCH 3/8] pinctrl: ralink: rt2880: return proper error code Sergio Paracuellos
2020-12-13 16:17 ` [PATCH 4/8] pinctrl: ralink: rt2880: add missing NULL check Sergio Paracuellos
2020-12-13 16:17 ` [PATCH 5/8] pinctrl: ralink: rt2880: delete not needed error message Sergio Paracuellos
2020-12-13 16:17 ` [PATCH 6/8] pinctrl: ralink: rt2880: preserve error codes Sergio Paracuellos
2020-12-13 16:17 ` [PATCH 7/8] pinctrl: ralink: rt2880: use 'PTR_ERR_OR_ZERO' Sergio Paracuellos
2020-12-13 16:17 ` [PATCH 8/8] staging: mt7621-dts: properly name pinctrl related nodes Sergio Paracuellos
2020-12-14 9:01 ` [PATCH 0/8] pinctrl: ralink: rt2880: Some minimal clean ups Linus Walleij
2020-12-14 9:39 ` Sergio Paracuellos
2021-01-04 14:39 ` Linus Walleij
2021-01-04 14:45 ` Sergio Paracuellos
2021-01-04 14:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201213161721.6514-2-sergio.paracuellos@gmail.com \
--to=sergio.paracuellos@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).