From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFC98C2BBCA for ; Wed, 16 Dec 2020 09:01:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92D6D23105 for ; Wed, 16 Dec 2020 09:01:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726196AbgLPJBa (ORCPT ); Wed, 16 Dec 2020 04:01:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbgLPJB3 (ORCPT ); Wed, 16 Dec 2020 04:01:29 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DD70C0613D6 for ; Wed, 16 Dec 2020 01:00:49 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id i9so22399945wrc.4 for ; Wed, 16 Dec 2020 01:00:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=WLnMTl1G6UwEqHqPjfyqMKiBfvdc90ZzGoJC/xgl6I0=; b=Y3o8yyHxKNnQruLSD0iOGnwzUKH1Xan//YDBmDEqTy8bIHhqvPhBbbGRQi/otav6lv l1+xAgdlvxpIuJDn3ZxrxmeKpiCy69VHQDttA3ADb3kK/U7Rj8wcwywb04CVzdzT6apH 8S8F36/LZxmDlcm8cr39DPhxidmTBKm2ppJV23mMGoeLg4Xh/4C8NgNjaeD2T3YS+0lr 5KgTHrjgttcFC7dwS0POXXrP4ieh1hd8g6f1Y5y0mUdHOEvtA6Lw3qK+HInIYQ22PzZF oyNivuYTN+Ocl499/Xu46X4kSKQoou6uJXNt23eWj9s81ITwdJgefmMG2Yue916jBRro GPAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=WLnMTl1G6UwEqHqPjfyqMKiBfvdc90ZzGoJC/xgl6I0=; b=IiRXjX54W52qAzaBl7crDRwRSOJDOkmKu+Kz4AlIypn2jK7JtO0uNtQDAkZjUg419S 7rkdO2FwueC85v8vmF2LDxitkjdqSPVxmpW06p9BIi5KMuUCCcIa4m1qkqaUe/XChP/f jjOpFm5UT2HS58YZ9SEHK9BohyhJPo4t6V1DpuBcfpP+D+9ownUkWWc83O5qbh1pHHpr tJ4mO1q7UUBjPujS8jfhLAF2aWmfzCw8WR0rkX65EFXJYJQ7zOW+D/D4LicIGrk61PcL iIt+UfR7o9pWhxpdUlIM44ISSA4nLop+pqNfQni+cvIra9dFGqNj/UgLkAl1cGR0Vi4C cNnQ== X-Gm-Message-State: AOAM53157mSOZkdUGBU/HSoQONaOr4QknXKYg7KZ13xtWGIvIGco3sgQ qrrKtJz+QScJ3TvY8q7c52UEbQ== X-Google-Smtp-Source: ABdhPJz+r6Xme90cLiDirEBfpRG5183hD9lrcdfx1lAqVbFG32jIzRm6jwG8cTWkOv8NKONNT3pAqA== X-Received: by 2002:a5d:6a88:: with SMTP id s8mr38005448wru.118.1608109247855; Wed, 16 Dec 2020 01:00:47 -0800 (PST) Received: from dell ([91.110.221.200]) by smtp.gmail.com with ESMTPSA id v125sm1804504wme.42.2020.12.16.01.00.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Dec 2020 01:00:47 -0800 (PST) Date: Wed, 16 Dec 2020 09:00:45 +0000 From: Lee Jones To: "Vaittinen, Matti" Cc: "lgirdwood@gmail.com" , "marek.vasut+renesas@gmail.com" , "yoshihiro.shimoda.uh@renesas.com" , "broonie@kernel.org" , "bgolaszewski@baylibre.com" , "linus.walleij@linaro.org" , linux-power , "linux-gpio@vger.kernel.org" , "khiem.nguyen.xt@renesas.com" , "linux-renesas-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 11/12] mfd: bd9571mwv: Make the driver more generic Message-ID: <20201216090045.GA207743@dell> References: <1608104275-13174-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1608104275-13174-12-git-send-email-yoshihiro.shimoda.uh@renesas.com> <4021c3f04bf8c4dcbcb015056455c4acf9e71b6b.camel@fi.rohmeurope.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4021c3f04bf8c4dcbcb015056455c4acf9e71b6b.camel@fi.rohmeurope.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, 16 Dec 2020, Vaittinen, Matti wrote: > > On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote: > > From: Khiem Nguyen > > > > Since the driver supports BD9571MWV PMIC only, > > this patch makes the functions and data structure become more generic > > so that it can support other PMIC variants as well. > > > > Signed-off-by: Khiem Nguyen > > [shimoda: rebase and refactor] > > Signed-off-by: Yoshihiro Shimoda > > Reviewed-by: Matti Vaittinen Please place any *-by tags *after* the other comments. Fortunately, the first one below was still on my screen, else I would have stopped reading here. > > --- > > drivers/mfd/bd9571mwv.c | 95 +++++++++++++++++++++++++++---- > > ------------ > > include/linux/mfd/bd9571mwv.h | 18 ++------ > > 2 files changed, 63 insertions(+), 50 deletions(-) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog