* [PATCH] pinctrl: mediatek: Fix fallback call path
@ 2020-12-28 9:04 Hsin-Yi Wang
2021-01-04 11:16 ` Sean Wang
2021-01-05 22:40 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Hsin-Yi Wang @ 2020-12-28 9:04 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Sean Wang, Linus Walleij, Matthias Brugger, Light Hsieh,
linux-mediatek, linux-gpio, linux-kernel, Enric Balletbo i Serra
Some SoCs, eg. mt8183, are using a pinconfig operation bias_set_combo.
The fallback path in mtk_pinconf_adv_pull_set() should also try this
operation.
Fixes: cafe19db7751 ("pinctrl: mediatek: Backward compatible to previous Mediatek's bias-pull usage")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index 7aeb552d16ce9..72f17f26acd80 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -920,6 +920,10 @@ int mtk_pinconf_adv_pull_set(struct mtk_pinctrl *hw,
err = hw->soc->bias_set(hw, desc, pullup);
if (err)
return err;
+ } else if (hw->soc->bias_set_combo) {
+ err = hw->soc->bias_set_combo(hw, desc, pullup, arg);
+ if (err)
+ return err;
} else {
return -ENOTSUPP;
}
--
2.29.2.729.g45daf8777d-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: mediatek: Fix fallback call path
2020-12-28 9:04 [PATCH] pinctrl: mediatek: Fix fallback call path Hsin-Yi Wang
@ 2021-01-04 11:16 ` Sean Wang
2021-01-05 22:40 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Sean Wang @ 2021-01-04 11:16 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: linux-arm Mailing List, Linus Walleij, Matthias Brugger,
Light Hsieh, moderated list:ARM/Mediatek SoC support,
open list:GPIO SUBSYSTEM, lkml, Enric Balletbo i Serra
On Mon, Dec 28, 2020 at 5:04 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> Some SoCs, eg. mt8183, are using a pinconfig operation bias_set_combo.
> The fallback path in mtk_pinconf_adv_pull_set() should also try this
> operation.
>
> Fixes: cafe19db7751 ("pinctrl: mediatek: Backward compatible to previous Mediatek's bias-pull usage")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Acked-by: Sean Wang <sean.wang@kernel.org>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index 7aeb552d16ce9..72f17f26acd80 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -920,6 +920,10 @@ int mtk_pinconf_adv_pull_set(struct mtk_pinctrl *hw,
> err = hw->soc->bias_set(hw, desc, pullup);
> if (err)
> return err;
> + } else if (hw->soc->bias_set_combo) {
> + err = hw->soc->bias_set_combo(hw, desc, pullup, arg);
> + if (err)
> + return err;
> } else {
> return -ENOTSUPP;
> }
> --
> 2.29.2.729.g45daf8777d-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: mediatek: Fix fallback call path
2020-12-28 9:04 [PATCH] pinctrl: mediatek: Fix fallback call path Hsin-Yi Wang
2021-01-04 11:16 ` Sean Wang
@ 2021-01-05 22:40 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-01-05 22:40 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Linux ARM, Sean Wang, Matthias Brugger, Light Hsieh,
moderated list:ARM/Mediatek SoC support, open list:GPIO SUBSYSTEM,
linux-kernel@vger.kernel.org, Enric Balletbo i Serra
On Mon, Dec 28, 2020 at 10:04 AM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
> Some SoCs, eg. mt8183, are using a pinconfig operation bias_set_combo.
> The fallback path in mtk_pinconf_adv_pull_set() should also try this
> operation.
>
> Fixes: cafe19db7751 ("pinctrl: mediatek: Backward compatible to previous Mediatek's bias-pull usage")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Patch applied for fixes!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-05 22:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-28 9:04 [PATCH] pinctrl: mediatek: Fix fallback call path Hsin-Yi Wang
2021-01-04 11:16 ` Sean Wang
2021-01-05 22:40 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).