From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Russell King <linux@armlinux.org.uk>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
Sascha Hauer <s.hauer@pengutronix.de>,
Ralph Sennhauser <ralph.sennhauser@gmail.com>,
linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/5] gpio: mvebu: make pwm .get_state closer to idempotent
Date: Wed, 13 Jan 2021 10:42:07 +0100 [thread overview]
Message-ID: <20210113094207.rh4u7zo7wf64p7uw@pengutronix.de> (raw)
In-Reply-To: <1d376a3500e11d8fd2ecaf9ca345977f011079af.1610529002.git.baruch@tkos.co.il>
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
On Wed, Jan 13, 2021 at 11:22:43AM +0200, Baruch Siach wrote:
> Round up the result of division in period/duty_cycle calculation to make
> the result closer to idempotent.
Maybe:
Round up the divisions in .get_state() to make applying the read out
configuration idempotent in most cases as .apply rounds down.
> Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Other than that:
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-13 9:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 9:22 [PATCH v2 0/5] gpio: mvebu: pwm fixes and improvements Baruch Siach
2021-01-13 9:22 ` [PATCH v2 1/5] gpio: mvebu: fix pwm .get_state period calculation Baruch Siach
2021-01-13 9:27 ` Uwe Kleine-König
2021-01-13 9:22 ` [PATCH v2 2/5] gpio: mvebu: improve pwm period calculation accuracy Baruch Siach
2021-01-13 9:22 ` [PATCH v2 3/5] gpio: mvebu: make pwm .get_state closer to idempotent Baruch Siach
2021-01-13 9:42 ` Uwe Kleine-König [this message]
2021-01-13 9:22 ` [PATCH v2 4/5] gpio: mvebu: don't limit pwm period/duty_cycle to UINT_MAX Baruch Siach
2021-01-13 9:22 ` [PATCH v2 5/5] gpio: mvebu: document zero pwm duty cycle limitation Baruch Siach
2021-01-18 13:45 ` [PATCH v2 0/5] gpio: mvebu: pwm fixes and improvements Linus Walleij
2021-01-18 14:59 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113094207.rh4u7zo7wf64p7uw@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=bgolaszewski@baylibre.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=gregory.clement@bootlin.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ralph.sennhauser@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).