From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [libgpiod][PATCH v2 3/7] treewide: rename BIAS_AS_IS to BIAS_UNKNOWN
Date: Mon, 18 Jan 2021 08:07:38 +0800 [thread overview]
Message-ID: <20210118000738.GB6841@sol> (raw)
In-Reply-To: <20210115103018.27704-4-brgl@bgdev.pl>
On Fri, Jan 15, 2021 at 11:30:14AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> When inspecting the current bias setting of a GPIO line, the AS_IS name
> of one of the possible values really means that the kernel uAPI can't
> determine the bias setting because it didn't set it itself. In this case
> it's better to change the name to BIAS_UNKNOWN to reflect that.
>
Your checkin comment incorporates some of my review comments, which were
actually a bit sloppy. While I didn't bother to correct myself for that
email, I'd rather the checkin comment be more precise.
Specifically, I was conflating gpiolib and the cdev uAPI. If the bias
is set via gpiolib then the uAPI will report it correctly. If it is set
otherwise then the setting is unknown to gpiolib and therefore the uAPI.
And I'm not sure if the DT example that I used in that email was a good
one. But say the hardware initialises with pull-up enabled. If it hasn't
also been set via gpiolib then it will be reported as unknown.
Cheers,
Kent.
next prev parent reply other threads:[~2021-01-18 0:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 10:30 [libgpiod][PATCH v2 0/7] treewide: remove more cruft and add some improvements Bartosz Golaszewski
2021-01-15 10:30 ` [libgpiod][PATCH v2 1/7] treewide: remove helpers for opening chips by name & number Bartosz Golaszewski
2021-01-15 10:30 ` [libgpiod][PATCH v2 2/7] treewide: simplify the active-low line property Bartosz Golaszewski
2021-01-15 10:30 ` [libgpiod][PATCH v2 3/7] treewide: rename BIAS_AS_IS to BIAS_UNKNOWN Bartosz Golaszewski
2021-01-18 0:07 ` Kent Gibson [this message]
2021-01-18 11:40 ` Bartosz Golaszewski
2021-01-19 0:27 ` Kent Gibson
2021-01-15 10:30 ` [libgpiod][PATCH v2 4/7] treewide: rename BIAS_DISABLE to BIAS_DISABLED Bartosz Golaszewski
2021-01-15 10:30 ` [libgpiod][PATCH v2 5/7] treewide: make drive settings an enum Bartosz Golaszewski
2021-01-15 10:30 ` [libgpiod][PATCH v2 6/7] bindings: cxx: line: reorder bias mapping entries Bartosz Golaszewski
2021-01-15 10:30 ` [libgpiod][PATCH v2 7/7] core: add the kernel uapi header to the repository Bartosz Golaszewski
2021-01-18 0:22 ` Kent Gibson
2021-01-18 9:57 ` Bartosz Golaszewski
2021-01-18 1:01 ` [libgpiod][PATCH v2 0/7] treewide: remove more cruft and add some improvements Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118000738.GB6841@sol \
--to=warthog618@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).