From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
Sascha Hauer <s.hauer@pengutronix.de>,
Ralph Sennhauser <ralph.sennhauser@gmail.com>,
linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 4/4] gpio: mvebu: improve handling of pwm zero on/off values
Date: Wed, 20 Jan 2021 18:24:49 +0100 [thread overview]
Message-ID: <20210120172449.z55oyiktpez76zwe@pengutronix.de> (raw)
In-Reply-To: <fb61ffe7275237715af92015b2216b8355feb0d6.1611128398.git.baruch@tkos.co.il>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On Wed, Jan 20, 2021 at 06:16:28PM +0200, Baruch Siach wrote:
> Hardware appears to treat zero value as 2^32. Take advantage of this
> fact to support on/off values of up to UINT_MAX+1 == 2^32. Adjust both
> .apply and .get_state to handle zero as a special case.
>
> Rounded up division result in .get_state can't be zero, since the
> dividend is now larger than 0. Remove check for this case.
>
> Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Analyzed-by: Russell King <linux@armlinux.org.uk>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-20 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 16:16 [PATCH v5 0/4] gpio: mvebu: pwm fixes and improvements Baruch Siach
2021-01-20 16:16 ` [PATCH v5 1/4] gpio: mvebu: improve pwm period calculation accuracy Baruch Siach
2021-01-20 16:16 ` [PATCH v5 2/4] gpio: mvebu: make pwm .get_state closer to idempotent Baruch Siach
2021-01-20 16:16 ` [PATCH v5 3/4] gpio: mvebu: don't limit pwm period/duty_cycle to UINT_MAX Baruch Siach
2021-01-20 16:16 ` [PATCH v5 4/4] gpio: mvebu: improve handling of pwm zero on/off values Baruch Siach
2021-01-20 17:24 ` Uwe Kleine-König [this message]
2021-01-25 9:43 ` [PATCH v5 0/4] gpio: mvebu: pwm fixes and improvements Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120172449.z55oyiktpez76zwe@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=bgolaszewski@baylibre.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=gregory.clement@bootlin.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ralph.sennhauser@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).