From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-gpio <linux-gpio@vger.kernel.org>
Subject: Re: [libgpiod][PATCH] COPYING: organize the licenses in a separate LICENSES directory
Date: Thu, 4 Feb 2021 17:56:26 +0800 [thread overview]
Message-ID: <20210204095626.GA38203@sol> (raw)
In-Reply-To: <CAMpxmJX99n4JtUyNVqkAa1kCuSBX3dtee-5CXSe3z4Bf+SnOHQ@mail.gmail.com>
On Thu, Feb 04, 2021 at 10:43:49AM +0100, Bartosz Golaszewski wrote:
> On Thu, Feb 4, 2021 at 2:19 AM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > On Wed, Feb 03, 2021 at 01:23:25PM +0100, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > >
> > > Add the LICENSES directory as suggested by Greg KH. It will contain the
> > > license files relevant to this project that is: LGPL-2.1 for the library
> > > and GPL-2.0 & the Linux-syscall-note for the Linux Kernel uAPI header.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > I see you are following the kernel licencing rules wrt license file
> > naming and formatting.
> > Have you considered following the REUSE spec, as Greg also suggested,
> > instead?
> >
> > Cheers,
> > Kent.
> >
>
> The library is tightly coupled with the kernel so I thought it's best
> to follow the same scheme. Every file also has an SPDX identifier so
> together this looks clean to me.
>
Sure, but if following the REUSE spec would make life easier for projects
built on top of libgpiod then I'm all for it.
The existing SPDX headers are REUSE compliant so you are actually quite
close to REUSE compliance already, but ironically the license files
themselves, both before and after your changes, aren't.
Cheers,
Kent.
prev parent reply other threads:[~2021-02-04 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 12:23 [libgpiod][PATCH] COPYING: organize the licenses in a separate LICENSES directory Bartosz Golaszewski
2021-02-04 1:19 ` Kent Gibson
2021-02-04 9:43 ` Bartosz Golaszewski
2021-02-04 9:56 ` Kent Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204095626.GA38203@sol \
--to=warthog618@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).