From: Shawn Guo <shawn.guo@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 1/2] pinctrl: qcom: handle tiles for ACPI boot
Date: Thu, 4 Mar 2021 13:24:38 +0800 [thread overview]
Message-ID: <20210304052437.GE17424@dragon> (raw)
In-Reply-To: <YD+10cmeWfppgj0I@smile.fi.intel.com>
On Wed, Mar 03, 2021 at 06:14:09PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 03, 2021 at 10:45:27PM +0800, Shawn Guo wrote:
> > On Wed, Mar 03, 2021 at 04:08:09PM +0200, Andy Shevchenko wrote:
> > > On Wed, Mar 03, 2021 at 09:26:21PM +0800, Shawn Guo wrote:
> > > > It's not always the case that DT and ACPI describe hardware resource in
> > > > the same schema, even for a single platform. For example, on SC8180X,
> > > > DT uses the tiles schema while ACPI describe memory resource as a single
> > > > region. It patches msm_pinctrl_probe() function to map tiles regions
> > > > only for DT. While for ACPI, it maps the single memory resource and
> > > > calculate tile bases with offsets passed from SoC data.
> > >
> > > ...
> > >
> > > > +#include <linux/acpi.h>
> > >
> > > There are at least two possibilities to avoid this:
> >
> > So could you explain why we should avoid including this header?
>
> Here you can include it, but it's quite huge in order to have just one little
> function out of it. But main point is it seems that relying on firmware type
> for the tiles support is fragile.
Okay, I'm not entirely happy about the tiles checking for so many
conditions, so looked for other way around. It turns out that
pinctrl-sdm845 driver sets an example for not using tiles at all. I
will send v3 to drop this tiles thing completely.
Shawn
next prev parent reply other threads:[~2021-03-04 5:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 13:26 [PATCH v2 0/2] Add ACPI support for SC8180X pinctrl driver Shawn Guo
2021-03-03 13:26 ` [PATCH v2 1/2] pinctrl: qcom: handle tiles for ACPI boot Shawn Guo
2021-03-03 14:08 ` Andy Shevchenko
2021-03-03 14:45 ` Shawn Guo
2021-03-03 16:14 ` Andy Shevchenko
2021-03-04 5:24 ` Shawn Guo [this message]
2021-03-03 13:26 ` [PATCH v2 2/2] pinctrl: qcom: sc8180x: add ACPI probe support Shawn Guo
2021-03-03 14:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210304052437.GE17424@dragon \
--to=shawn.guo@linaro.org \
--cc=andriy.shevchenko@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).