From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCC0AC433E0 for ; Thu, 4 Mar 2021 05:26:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BDA264EFD for ; Thu, 4 Mar 2021 05:26:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234013AbhCDFZn (ORCPT ); Thu, 4 Mar 2021 00:25:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234115AbhCDFZY (ORCPT ); Thu, 4 Mar 2021 00:25:24 -0500 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97C3BC061756 for ; Wed, 3 Mar 2021 21:24:44 -0800 (PST) Received: by mail-pj1-x102a.google.com with SMTP id jx13so5802925pjb.1 for ; Wed, 03 Mar 2021 21:24:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eF3ouK2tt5RggVqVE4tZ8JPzVe8Y7mIM7tF/ZggEiY8=; b=hdbTIegP1vwRxV46VZzfJgU0cNqGnWP/UjMRcKYRZAClQyp6SYjuMkVrndTK/7la7g SVTk1mlp92vWAyNIMQDgjfWTfUsWjjK85sErjxdCivQBnqnWBR8iUKiDl8iRcdOk85gB EqFuVgnVJrhrdRsUGuOJkOz4ZcYufuzk/MpfkaNAaX1d3qrR+0fKRewIyUD+A7aHozpW 5iVQsdw89sqMPGVwXKX5PwRia3b7TDHYQsf7OQebhleK9M+4nltG3IKVRSHmRw43la/U 81+o/e795XL8UizwJ7D9/9t2O6RZV8sQBXJF70YpAIeJZwbsEDeBndSQzsBVVv8jKZir psRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eF3ouK2tt5RggVqVE4tZ8JPzVe8Y7mIM7tF/ZggEiY8=; b=QHr2dsMT4SI1Kr5TNsioyVVRq+VQ9OuDza/R2OF1bRQM/ZGKW40H4/qb2DO0DY1CeO pLDDDXyRwz0BWYy8e04dZxqPr9sfR4IPKQy7NoURcMdNePYYG3SwLFp8lih2JXD9aOD4 F3fXEjjEtoCYJEIherCLYaqqfQL3XrHWvaGNuiUf8Wxd4s0h8hdKqZaCXPLn9HfrVDeA BYx1en0FNq4j5NyfO3xwrKPgRta9NiEYDQ4zQ7Q5jYrnSBRYIvwvGYNUbeGe0/zRuNs+ ++N5wtlZiEJ4BV9wTEVc+SHfizzWGwkvdMHfuXa4Qg/jPlyGLZulQAeMGl/+5tABRri+ aFzQ== X-Gm-Message-State: AOAM533dnmyRAUQDdzGwHmMrieYMqHAFPHWcsyBGaB2x8Nw5fQsLp3Kb R1pRzRj1/Y0pNfzNRfG39fgo+A== X-Google-Smtp-Source: ABdhPJwV+8E5f6x7ijD6rKI2G4thN4e1CZ83qzpkuhoNGfzMuhUCHk7GJ8ZPHqExxqf273LGRIEASw== X-Received: by 2002:a17:90a:d585:: with SMTP id v5mr2716351pju.206.1614835484122; Wed, 03 Mar 2021 21:24:44 -0800 (PST) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id x9sm8261323pjp.3.2021.03.03.21.24.42 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Mar 2021 21:24:43 -0800 (PST) Date: Thu, 4 Mar 2021 13:24:38 +0800 From: Shawn Guo To: Andy Shevchenko Cc: Linus Walleij , Bjorn Andersson , linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 1/2] pinctrl: qcom: handle tiles for ACPI boot Message-ID: <20210304052437.GE17424@dragon> References: <20210303132622.4115-1-shawn.guo@linaro.org> <20210303132622.4115-2-shawn.guo@linaro.org> <20210303144526.GC17424@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Mar 03, 2021 at 06:14:09PM +0200, Andy Shevchenko wrote: > On Wed, Mar 03, 2021 at 10:45:27PM +0800, Shawn Guo wrote: > > On Wed, Mar 03, 2021 at 04:08:09PM +0200, Andy Shevchenko wrote: > > > On Wed, Mar 03, 2021 at 09:26:21PM +0800, Shawn Guo wrote: > > > > It's not always the case that DT and ACPI describe hardware resource in > > > > the same schema, even for a single platform. For example, on SC8180X, > > > > DT uses the tiles schema while ACPI describe memory resource as a single > > > > region. It patches msm_pinctrl_probe() function to map tiles regions > > > > only for DT. While for ACPI, it maps the single memory resource and > > > > calculate tile bases with offsets passed from SoC data. > > > > > > ... > > > > > > > +#include > > > > > > There are at least two possibilities to avoid this: > > > > So could you explain why we should avoid including this header? > > Here you can include it, but it's quite huge in order to have just one little > function out of it. But main point is it seems that relying on firmware type > for the tiles support is fragile. Okay, I'm not entirely happy about the tiles checking for so many conditions, so looked for other way around. It turns out that pinctrl-sdm845 driver sets an example for not using tiles at all. I will send v3 to drop this tiles thing completely. Shawn