From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C868EC433E0 for ; Tue, 9 Mar 2021 02:57:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B09565287 for ; Tue, 9 Mar 2021 02:57:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229520AbhCIC4n (ORCPT ); Mon, 8 Mar 2021 21:56:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbhCIC4L (ORCPT ); Mon, 8 Mar 2021 21:56:11 -0500 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FFC0C06175F for ; Mon, 8 Mar 2021 18:56:11 -0800 (PST) Received: by mail-pg1-x52a.google.com with SMTP id p21so7775120pgl.12 for ; Mon, 08 Mar 2021 18:56:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MTVRu5yw/uigruS/X6nQpYJMpGUlZBH0fqHFAAjdGBk=; b=QVGUGB5wW80JZiTEWVUJ1QjWJprQu9OwtqDNCJ4x9a31PT/+mPZuefl6gkIQV0v7zb 2cZZL9JROl8aQD6lFxbKJhsv51lQKiqS9xRMKXtABItJCWHYzSEkaghs7Ld3WcYtKL+A bAZjphIu7tOOud4/LT8KVvDD8/tVCxQ9AC8Uz8FfoywQ8IVVAnGD90IeoLFNPDG2xL6V vcIKgAET+1VX0IBuMa9HHLFzzuVBIUZmLZBktchtB0/tPJSoE9sftcPkz9KXGwmTtBk4 yJf9h4WpnBUpuwce3AicZ3st40Hw8BrsgDXUbOY2dcm4BkVTuo7VZFrZTZURv2ByLPge 4NKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MTVRu5yw/uigruS/X6nQpYJMpGUlZBH0fqHFAAjdGBk=; b=ar6nq7s116yCP+OzRe99mXM2ZnBJDAac5yoQyDAbMPn/GYsDOWpsQ3RQ4DzqpwZE/L gfOkWBaNUVtoCh9epHXNQXiiXW6vBIGONuuzQ8jkv7k9CgIG0FrK+6EEN8lKjGKtRlGn hZF0s92GEfqtRXNZt4ymkHVW8uW7d9UZ8Ii/cDsl/jFDGrYVSagR81hZu2l6WZ3/LDh4 m9JRkXvOVCqAoGRmactLe7l7Kxi4baRU6cWeFmQd9eZJgMsFOj0chfjbAbWSXk0KiISJ tGLWUvyQElGgJDJb7zkJU/mFLyC1oDwzo2YWQ7spa23D+0zLpTZFe1acp6gnkkcSmFUN RGiw== X-Gm-Message-State: AOAM531VCHjGBd6lB+ICPXhIlT9KPhfUVcR4ubi5yS1HFciw6BBCN2ki iHYtSge4vdMCOX9vse2s5elBLg== X-Google-Smtp-Source: ABdhPJw+2mldQAb6JMJ35KRdSOcpZPGxbTNkRRYgTRtl6NnFsp2B5a8DfrCGyMIVthwps542geKkig== X-Received: by 2002:a63:cb0e:: with SMTP id p14mr23065574pgg.370.1615258571020; Mon, 08 Mar 2021 18:56:11 -0800 (PST) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id mu6sm644585pjb.35.2021.03.08.18.56.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Mar 2021 18:56:10 -0800 (PST) Date: Tue, 9 Mar 2021 10:56:05 +0800 From: Shawn Guo To: Bjorn Andersson Cc: Linus Walleij , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v3 1/2] pinctrl: qcom: sc8180x: drop the use of tiles Message-ID: <20210309025604.GQ17424@dragon> References: <20210304060520.24975-1-shawn.guo@linaro.org> <20210304060520.24975-2-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Mar 08, 2021 at 07:08:00PM -0600, Bjorn Andersson wrote: > On Thu 04 Mar 00:05 CST 2021, Shawn Guo wrote: > > > To support both ACPI and DT, it makes more sense to not use tiles for > > pinctrl-sc8180x driver, as ACPI table describes TLMM block with one > > single memory resource. Since DTS of SC8180X hasn't landed, there is > > still chance to align DT description with ACPI. > > > > I don't like the idea that we make up addresses to put in the DT to fit > what was put in the DSDT. It is 3 different memory regions, with things > in-between that Linux shouldn't touch. This is not a new idea but something pinctrl-sdm845 has been doing for years. And IMHO, it's not a bad idea but a reasonable compromise. > Isn't it possible to during ACPI probe take reg 0 and register the 3 > named regions instead? It is possible. But let's see what it takes. We will need to have some quirk handling in the ACPI core to detect TLMM device on Flex 5G machine, and then override the memory resource registration for that device. Myself is not even convinced this is a good solution, not mentioning whether ACPI maintainers will accept it. Shawn