From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [libgpiod][PATCH 0/6] treewide: another bunch of cleanups for v2.0
Date: Tue, 9 Mar 2021 14:26:33 +0100 [thread overview]
Message-ID: <20210309132639.29069-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Kent suggested I send the patches for v2.0 API in smaller batches for earlier
review instead of dropping a huge patch bomb that will require more work from
my side and may later be negatively reviewed so here's a hopefully the last
part of cleanups that can go into master already before first patches with the
new C API will drop.
The idea for the new C API is this: all objects are opaque and refcounted. This
is why the chip was converted to reference counting. Lines were removed and
their functionality split into line_info and line_request, this is why I'm
reworking line lookup to return the HW offset within a chip and not the line
object. Other patches are mostly cleanups and cruft shave-off.
Bartosz Golaszewski (6):
treewide: simplify line lookup
tests: remove line bulk test cases
core: switch to reference counting for gpio chip objects
treewide: remove is_requested() and is_free()
treewide: kill line updating
core: hide the GPIOD_API symbol
bindings/cxx/Makefile.am | 2 +-
bindings/cxx/chip.cpp | 54 +++---
bindings/cxx/examples/gpiofindcxx.cpp | 7 +-
bindings/cxx/gpiod.hpp | 249 ++++++++++++-------------
bindings/cxx/internal.hpp | 9 +
bindings/cxx/iter.cpp | 18 +-
bindings/cxx/line.cpp | 86 ++++-----
bindings/cxx/line_bulk.cpp | 78 ++++----
bindings/cxx/tests/tests-chip.cpp | 6 +-
bindings/cxx/tests/tests-line.cpp | 57 ------
bindings/python/examples/gpiofind.py | 7 +-
bindings/python/gpiodmodule.c | 101 ++--------
bindings/python/tests/gpiod_py_test.py | 49 +----
include/gpiod.h | 229 +++++++++--------------
lib/Makefile.am | 2 +-
lib/core.c | 195 ++++++++++---------
lib/helpers.c | 155 ++++++---------
lib/internal.h | 11 ++
lib/misc.c | 4 +-
tests/Makefile.am | 1 -
tests/gpiod-test.h | 2 +-
tests/tests-bulk.c | 145 --------------
tests/tests-chip.c | 17 +-
tools/gpiodetect.c | 2 +-
tools/gpiofind.c | 11 +-
tools/gpioget.c | 2 +-
tools/gpioinfo.c | 4 +-
tools/gpiomon.c | 2 +-
tools/gpioset.c | 2 +-
29 files changed, 547 insertions(+), 960 deletions(-)
create mode 100644 bindings/cxx/internal.hpp
create mode 100644 lib/internal.h
delete mode 100644 tests/tests-bulk.c
--
2.30.1
next reply other threads:[~2021-03-09 13:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 13:26 Bartosz Golaszewski [this message]
2021-03-09 13:26 ` [libgpiod][PATCH 1/6] treewide: simplify line lookup Bartosz Golaszewski
2021-03-09 13:26 ` [libgpiod][PATCH 2/6] tests: remove line bulk test cases Bartosz Golaszewski
2021-03-09 13:26 ` [libgpiod][PATCH 3/6] core: switch to reference counting for gpio chip objects Bartosz Golaszewski
2021-03-09 13:26 ` [libgpiod][PATCH 4/6] treewide: remove is_requested() and is_free() Bartosz Golaszewski
2021-03-09 13:26 ` [libgpiod][PATCH 5/6] treewide: kill line updating Bartosz Golaszewski
2021-03-09 13:26 ` [libgpiod][PATCH 6/6] core: hide the GPIOD_API symbol Bartosz Golaszewski
2021-03-09 15:07 ` Andy Shevchenko
2021-03-09 15:18 ` Bartosz Golaszewski
2021-03-09 15:28 ` Andy Shevchenko
2021-03-17 10:25 ` [libgpiod][PATCH 0/6] treewide: another bunch of cleanups for v2.0 Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309132639.29069-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).