From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-kbuild@vger.kernel.org
Cc: linux-gpio@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Paul Cercueil <paul@crapouillou.net>,
Masahiro Yamada <masahiroy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Subject: [PATCH 1/2] linux/kconfig.h: replace IF_ENABLED() with PTR_IF() in <linux/kernel.h>
Date: Fri, 9 Apr 2021 05:58:57 +0900 [thread overview]
Message-ID: <20210408205858.51751-2-masahiroy@kernel.org> (raw)
In-Reply-To: <20210408205858.51751-1-masahiroy@kernel.org>
<linux/kconfig.h> is included from all the kernel-space source files,
including C, assembly, linker scripts. It is intended to contain minimal
set of macros to evaluate CONFIG options.
IF_ENABLED() is an intruder here because (x ? y : z) is C code, which
should not be included from assembly files or linker scripts.
Also, <linux/kconfig.h> is no longer self-contained because NULL is
defined in <linux/stddef.h>.
Move IF_ENABLED() out to <linux/kernel.h> as PTR_IF().
PTR_IF(IS_ENABLED(CONFIG_FOO), ...) is slightly longer than
IF_ENABLED(CONFIG_FOO, ...), but it is not a big deal because
sub-systems often define dedicated macros such as of_match_ptr(),
pm_ptr() etc. for common use-cases.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
drivers/pinctrl/pinctrl-ingenic.c | 20 ++++++++++----------
include/linux/kconfig.h | 6 ------
include/linux/kernel.h | 2 ++
3 files changed, 12 insertions(+), 16 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c
index f2746125b077..b21e2ae4528d 100644
--- a/drivers/pinctrl/pinctrl-ingenic.c
+++ b/drivers/pinctrl/pinctrl-ingenic.c
@@ -2496,43 +2496,43 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev)
static const struct of_device_id ingenic_pinctrl_of_match[] = {
{
.compatible = "ingenic,jz4740-pinctrl",
- .data = IF_ENABLED(CONFIG_MACH_JZ4740, &jz4740_chip_info)
+ .data = PTR_IF(IS_ENABLED(CONFIG_MACH_JZ4740), &jz4740_chip_info)
},
{
.compatible = "ingenic,jz4725b-pinctrl",
- .data = IF_ENABLED(CONFIG_MACH_JZ4725B, &jz4725b_chip_info)
+ .data = PTR_IF(IS_ENABLED(CONFIG_MACH_JZ4725B), &jz4725b_chip_info)
},
{
.compatible = "ingenic,jz4760-pinctrl",
- .data = IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)
+ .data = PTR_IF(IS_ENABLED(CONFIG_MACH_JZ4760), &jz4760_chip_info)
},
{
.compatible = "ingenic,jz4760b-pinctrl",
- .data = IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)
+ .data = PTR_IF(IS_ENABLED(CONFIG_MACH_JZ4760), &jz4760_chip_info)
},
{
.compatible = "ingenic,jz4770-pinctrl",
- .data = IF_ENABLED(CONFIG_MACH_JZ4770, &jz4770_chip_info)
+ .data = PTR_IF(IS_ENABLED(CONFIG_MACH_JZ4770), &jz4770_chip_info)
},
{
.compatible = "ingenic,jz4780-pinctrl",
- .data = IF_ENABLED(CONFIG_MACH_JZ4780, &jz4780_chip_info)
+ .data = PTR_IF(IS_ENABLED(CONFIG_MACH_JZ4780), &jz4780_chip_info)
},
{
.compatible = "ingenic,x1000-pinctrl",
- .data = IF_ENABLED(CONFIG_MACH_X1000, &x1000_chip_info)
+ .data = PTR_IF(IS_ENABLED(CONFIG_MACH_X1000), &x1000_chip_info)
},
{
.compatible = "ingenic,x1000e-pinctrl",
- .data = IF_ENABLED(CONFIG_MACH_X1000, &x1000_chip_info)
+ .data = PTR_IF(IS_ENABLED(CONFIG_MACH_X1000), &x1000_chip_info)
},
{
.compatible = "ingenic,x1500-pinctrl",
- .data = IF_ENABLED(CONFIG_MACH_X1500, &x1500_chip_info)
+ .data = PTR_IF(IS_ENABLED(CONFIG_MACH_X1500), &x1500_chip_info)
},
{
.compatible = "ingenic,x1830-pinctrl",
- .data = IF_ENABLED(CONFIG_MACH_X1830, &x1830_chip_info)
+ .data = PTR_IF(IS_ENABLED(CONFIG_MACH_X1830), &x1830_chip_info)
},
{ /* sentinel */ },
};
diff --git a/include/linux/kconfig.h b/include/linux/kconfig.h
index 24a59cb06963..cc8fa109cfa3 100644
--- a/include/linux/kconfig.h
+++ b/include/linux/kconfig.h
@@ -70,10 +70,4 @@
*/
#define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option))
-/*
- * IF_ENABLED(CONFIG_FOO, ptr) evaluates to (ptr) if CONFIG_FOO is set to 'y'
- * or 'm', NULL otherwise.
- */
-#define IF_ENABLED(option, ptr) (IS_ENABLED(option) ? (ptr) : NULL)
-
#endif /* __LINUX_KCONFIG_H */
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 5b7ed6dc99ac..8685ca4cf287 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -38,6 +38,8 @@
#define PTR_ALIGN_DOWN(p, a) ((typeof(p))ALIGN_DOWN((unsigned long)(p), (a)))
#define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0)
+#define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
+
/* generic data direction definitions */
#define READ 0
#define WRITE 1
--
2.27.0
next prev parent reply other threads:[~2021-04-08 21:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 20:58 [PATCH 0/2] linux/kconfig.h: move IF_ENABLED() out of <linux/kconfig.h> Masahiro Yamada
2021-04-08 20:58 ` Masahiro Yamada [this message]
2021-04-09 8:15 ` [PATCH 1/2] linux/kconfig.h: replace IF_ENABLED() with PTR_IF() in <linux/kernel.h> Paul Cercueil
2021-04-09 8:30 ` Masahiro Yamada
2021-04-09 9:38 ` Paul Cercueil
2021-04-09 9:24 ` Andy Shevchenko
2021-04-10 3:52 ` Masahiro Yamada
2021-04-08 20:58 ` [PATCH 2/2] pm: allow drivers to drop #ifdef and __maybe_unused from pm callbacks Masahiro Yamada
2021-04-08 21:29 ` Arnd Bergmann
2021-04-09 3:17 ` Masahiro Yamada
2021-04-08 23:49 ` kernel test robot
2021-04-08 23:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408205858.51751-2-masahiroy@kernel.org \
--to=masahiroy@kernel.org \
--cc=arnd@arndb.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).