* [PATCH v1 1/1] gpio: mockup: Switch to use gpiochip_get_desc()
@ 2021-05-10 19:52 Andy Shevchenko
2021-05-12 11:42 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2021-05-10 19:52 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Shevchenko, linux-gpio, linux-kernel
Cc: Bamvor Jian Zhang, Linus Walleij
Switch to use gpiochip_get_desc() helper.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpio-mockup.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index d7e73876a3b9..0a9d746a0fe0 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -144,12 +144,9 @@ static void gpio_mockup_set_multiple(struct gpio_chip *gc,
static int gpio_mockup_apply_pull(struct gpio_mockup_chip *chip,
unsigned int offset, int value)
{
+ struct gpio_chip *gc = &chip->gc;
+ struct gpio_desc *desc = gpiochip_get_desc(gc, offset);
int curr, irq, irq_type, ret = 0;
- struct gpio_desc *desc;
- struct gpio_chip *gc;
-
- gc = &chip->gc;
- desc = &gc->gpiodev->descs[offset];
mutex_lock(&chip->lock);
@@ -369,7 +366,7 @@ static void gpio_mockup_debugfs_setup(struct device *dev,
priv->chip = chip;
priv->offset = i;
- priv->desc = &gc->gpiodev->descs[i];
+ priv->desc = gpiochip_get_desc(gc, i);
debugfs_create_file(name, 0200, chip->dbg_dir, priv,
&gpio_mockup_debugfs_ops);
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1 1/1] gpio: mockup: Switch to use gpiochip_get_desc()
2021-05-10 19:52 [PATCH v1 1/1] gpio: mockup: Switch to use gpiochip_get_desc() Andy Shevchenko
@ 2021-05-12 11:42 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2021-05-12 11:42 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-gpio, LKML, Bamvor Jian Zhang, Linus Walleij
On Mon, May 10, 2021 at 9:52 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Switch to use gpiochip_get_desc() helper.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/gpio/gpio-mockup.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
> index d7e73876a3b9..0a9d746a0fe0 100644
> --- a/drivers/gpio/gpio-mockup.c
> +++ b/drivers/gpio/gpio-mockup.c
> @@ -144,12 +144,9 @@ static void gpio_mockup_set_multiple(struct gpio_chip *gc,
> static int gpio_mockup_apply_pull(struct gpio_mockup_chip *chip,
> unsigned int offset, int value)
> {
> + struct gpio_chip *gc = &chip->gc;
> + struct gpio_desc *desc = gpiochip_get_desc(gc, offset);
> int curr, irq, irq_type, ret = 0;
> - struct gpio_desc *desc;
> - struct gpio_chip *gc;
> -
> - gc = &chip->gc;
> - desc = &gc->gpiodev->descs[offset];
>
> mutex_lock(&chip->lock);
>
> @@ -369,7 +366,7 @@ static void gpio_mockup_debugfs_setup(struct device *dev,
>
> priv->chip = chip;
> priv->offset = i;
> - priv->desc = &gc->gpiodev->descs[i];
> + priv->desc = gpiochip_get_desc(gc, i);
>
> debugfs_create_file(name, 0200, chip->dbg_dir, priv,
> &gpio_mockup_debugfs_ops);
> --
> 2.30.2
>
Patch applied, thanks!
Bartosz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-12 11:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-10 19:52 [PATCH v1 1/1] gpio: mockup: Switch to use gpiochip_get_desc() Andy Shevchenko
2021-05-12 11:42 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).