Re: [PATCH v1 1/1] gpiolib: Introduce for_each_gpio_desc() macro

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3673 bytes --]

Hi Andy,

I love your patch! Perhaps something to improve:

[auto build test WARNING on gpio/for-next]
[also build test WARNING on v5.13-rc1 next-20210510]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/gpiolib-Introduce-for_each_gpio_desc-macro/20210511-035305
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: h8300-randconfig-r012-20210510 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ceaf41face19ca3a36b81b3b866c1708a90cb4e2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andy-Shevchenko/gpiolib-Introduce-for_each_gpio_desc-macro/20210511-035305
        git checkout ceaf41face19ca3a36b81b3b866c1708a90cb4e2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpio/gpiolib-of.c: In function 'of_gpiochip_remove_hog':
>> drivers/gpio/gpiolib-of.c:718:36: warning: passing argument 2 of 'test_bit' makes pointer from integer without a cast [-Wint-conversion]
     718 |   if (test_bit(FLAG_IS_HOGGED, desc->flags) && desc->hog == hog)
         |                                ~~~~^~~~~~~
         |                                    |
         |                                    long unsigned int
   In file included from include/linux/bitops.h:29,
                    from include/linux/kernel.h:12,
                    from include/asm-generic/bug.h:20,
                    from arch/h8300/include/asm/bug.h:8,
                    from include/linux/bug.h:5,
                    from include/linux/thread_info.h:12,
                    from include/asm-generic/current.h:5,
                    from ./arch/h8300/include/generated/asm/current.h:1,
                    from include/linux/sched.h:12,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from drivers/gpio/gpiolib-of.c:10:
   arch/h8300/include/asm/bitops.h:63:66: note: expected 'const volatile long unsigned int *' but argument is of type 'long unsigned int'
      63 | static inline int test_bit(int nr, const volatile unsigned long *addr)
         |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~


vim +/test_bit +718 drivers/gpio/gpiolib-of.c

   704	
   705	#ifdef CONFIG_OF_DYNAMIC
   706	/**
   707	 * of_gpiochip_remove_hog - Remove all hogs in a hog device node
   708	 * @chip:	gpio chip to act on
   709	 * @hog:	device node describing the hogs
   710	 */
   711	static void of_gpiochip_remove_hog(struct gpio_chip *chip,
   712					   struct device_node *hog)
   713	{
   714		struct gpio_desc *desc;
   715		unsigned int i;
   716	
   717		for_each_gpio_desc(i, chip, desc) {
 > 718			if (test_bit(FLAG_IS_HOGGED, desc->flags) && desc->hog == hog)
   719				gpiochip_free_own_desc(desc);
   720		}
   721	}
   722	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27774 bytes --]