* [PATCH] gpio: pca953x: Add support for the On Semi pca9655
@ 2021-06-13 22:03 Peter Robinson
2021-06-14 8:10 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Peter Robinson @ 2021-06-13 22:03 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, linux-gpio; +Cc: Peter Robinson
The On Semi pca9655 is a 16 bit variant of the On Semi pca9654 GPIO
expander, with 16 GPIOs and interrupt functionality.
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
drivers/gpio/gpio-pca953x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index c91d05651596..348040247b0b 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -1241,6 +1241,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
{ .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
{ .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), },
+ { .compatible = "onnn,pca9655", .data = OF_953X( 16, PCA_INT), },
{ .compatible = "exar,xra1202", .data = OF_953X( 8, 0), },
{ }
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: pca953x: Add support for the On Semi pca9655
2021-06-13 22:03 [PATCH] gpio: pca953x: Add support for the On Semi pca9655 Peter Robinson
@ 2021-06-14 8:10 ` Andy Shevchenko
2021-06-16 19:28 ` Bartosz Golaszewski
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2021-06-14 8:10 UTC (permalink / raw)
To: Peter Robinson
Cc: Linus Walleij, Bartosz Golaszewski, open list:GPIO SUBSYSTEM
On Mon, Jun 14, 2021 at 1:05 AM Peter Robinson <pbrobinson@gmail.com> wrote:
>
> The On Semi pca9655 is a 16 bit variant of the On Semi pca9654 GPIO
> expander, with 16 GPIOs and interrupt functionality.
I don't remember the context...
> { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
> { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), },
> + { .compatible = "onnn,pca9655", .data = OF_953X( 16, PCA_INT), },
...but the first space (before 16) seems not necessary and the idea as
far as I can see from here is to have those columns to be indented
nicely.
> { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), },
> { }
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: pca953x: Add support for the On Semi pca9655
2021-06-14 8:10 ` Andy Shevchenko
@ 2021-06-16 19:28 ` Bartosz Golaszewski
2021-06-17 7:37 ` Peter Robinson
0 siblings, 1 reply; 4+ messages in thread
From: Bartosz Golaszewski @ 2021-06-16 19:28 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Peter Robinson, Linus Walleij, open list:GPIO SUBSYSTEM
On Mon, Jun 14, 2021 at 10:10 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Mon, Jun 14, 2021 at 1:05 AM Peter Robinson <pbrobinson@gmail.com> wrote:
> >
> > The On Semi pca9655 is a 16 bit variant of the On Semi pca9654 GPIO
> > expander, with 16 GPIOs and interrupt functionality.
>
> I don't remember the context...
>
> > { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
> > { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), },
> > + { .compatible = "onnn,pca9655", .data = OF_953X( 16, PCA_INT), },
>
> ...but the first space (before 16) seems not necessary and the idea as
> far as I can see from here is to have those columns to be indented
> nicely.
>
> > { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), },
> > { }
>
> --
> With Best Regards,
> Andy Shevchenko
I applied the patch and fixed the indentation problem in my tree. Thanks!
Bart
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: pca953x: Add support for the On Semi pca9655
2021-06-16 19:28 ` Bartosz Golaszewski
@ 2021-06-17 7:37 ` Peter Robinson
0 siblings, 0 replies; 4+ messages in thread
From: Peter Robinson @ 2021-06-17 7:37 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Andy Shevchenko, Linus Walleij, open list:GPIO SUBSYSTEM
On Wed, Jun 16, 2021 at 8:28 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
>
> On Mon, Jun 14, 2021 at 10:10 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Mon, Jun 14, 2021 at 1:05 AM Peter Robinson <pbrobinson@gmail.com> wrote:
> > >
> > > The On Semi pca9655 is a 16 bit variant of the On Semi pca9654 GPIO
> > > expander, with 16 GPIOs and interrupt functionality.
> >
> > I don't remember the context...
> >
> > > { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
> > > { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), },
> > > + { .compatible = "onnn,pca9655", .data = OF_953X( 16, PCA_INT), },
> >
> > ...but the first space (before 16) seems not necessary and the idea as
> > far as I can see from here is to have those columns to be indented
> > nicely.
> >
> > > { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), },
> > > { }
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
>
> I applied the patch and fixed the indentation problem in my tree. Thanks!
Awesome, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-17 7:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-13 22:03 [PATCH] gpio: pca953x: Add support for the On Semi pca9655 Peter Robinson
2021-06-14 8:10 ` Andy Shevchenko
2021-06-16 19:28 ` Bartosz Golaszewski
2021-06-17 7:37 ` Peter Robinson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).