Re: [libgpiod][PATCH 4/4] bindings: cxx: implement C++ bindings for libgpiod v2.0

[Kent Gibson <warthog618@gmail.com>]

On Mon, Jun 28, 2021 at 02:30:05PM +0300, Andy Shevchenko wrote:
> On Sun, Jun 27, 2021 at 04:47:57PM +0800, Kent Gibson wrote:
> > On Mon, Jun 21, 2021 at 09:18:30PM +0200, Bartosz Golaszewski wrote:
> > > This is the bulk of work implementing C++ bindings for the new libgpiod
> > > API. The tests are not converted yet but the examples are fully
> > > functional. More details in the cover letter as this patch will be
> > > squashed with the one for the core C library anyway.
> > 
> > Firstly, I don't have any problems with patches 1-3.
> > 
> > Secondly, I'll be focussing on the API here, but I'm not up on current C++
> > best practice, so take my comments, or the absence of them, with a
> > suitable dose of salt.
> > 
> > A general comment - you use retrieve/read/get/return for essentially the
> > same thing in the accessor method documentation.
> > Perhaps you could settle on one?
> > Variety may be the spice of life, but sometimes boring is better.
> 
> It's a weak point of many documentation files that I saw :-)
> Nevertheless, it's good practice to define terms in the preface pages to be
> sure everybody is on the same page with meaning of them.
> 
> Kent, do I understand correctly that Go bindings use C library?
> 

No, the Go library is pure Go - it makes the ioctl calls itself.

Cheers,
Kent.