From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A648BC07E95 for ; Wed, 7 Jul 2021 13:51:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87F1E61C89 for ; Wed, 7 Jul 2021 13:51:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231860AbhGGNyi (ORCPT ); Wed, 7 Jul 2021 09:54:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231852AbhGGNyi (ORCPT ); Wed, 7 Jul 2021 09:54:38 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C08A7C061574 for ; Wed, 7 Jul 2021 06:51:56 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id m1so3464015edq.8 for ; Wed, 07 Jul 2021 06:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=deviqon.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Om6iSfTd+vuFEObQd4saIskSqlXiWy6xm+bnPnRsnvM=; b=EXIxVC/xqH5Wcgj8WWZ6dgpi/n/hdiuDu03kYBnxBuqOnoUZDwOPECWYwFA/1iXpul c8b5NQXmZ8yQ89HhVRgpzHEDpNkGl4I081emt8h8d/G8gfhjFlwLg/rkfMSfGgJjKx2h w0076oLkeaSEZet5HYXhInu9Zukcd1hNGvn6ayEs1jdJ5v4tEPEf82Mjo2goYa2uEvWN O9HEX2NDxJd65OQlCYD7r4JR3GElqdys5Q92y6THUyyRRzxT4A3KL6O8/lA91iUKAxBt ZHFriX0x+Kxe9Ee/aAGuwUWykaoEHeGZZ4q7T2cvnhjYnvL34rpkAbdh6X6DDWMTMw25 9KMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Om6iSfTd+vuFEObQd4saIskSqlXiWy6xm+bnPnRsnvM=; b=amQKw5Rtdo0hRUZuX2S8uIxhIQwp4sA29yKQ0hWNW1eeq9OykYpj7XogOmPos5XTWX YjILJc2hlbhKc5H9j9GzoLj24c1sh75iDmeeY7yHaV8AI3QQEXSxl1kLTIwEv0aCrMwC HQBUJ+bkxP6yqTskz0Jd3glK8j6HdnOe2/qftAAJotn5oV5xgTG2cg24xApMFzfCmStz 0EqZxqY2zFlI4wfCVIf2pnYV0yOYF6249/aUF/JG5zFK+8nWSp1BsupOYl4N5BRs4wNW RzxW90D8CBi14m6WwBtU0DbSNicQMS08VlNIAALsVykVQ4ySOlHJ7EeM5EBK26wh1PA+ 24Bg== X-Gm-Message-State: AOAM532AgaFhkciFD2NSjfLT9aBHeDmgsu42scOpJ9Gc56W//XVqZ7Sf CUTyUmQj18Jprg+4JQfzZRCzV/AfzgGsJrfh+ik= X-Google-Smtp-Source: ABdhPJx8otZSVijGppqQTHTQynIG1zWrQfSAUKbkmY5v8N9C+Vxt6c1RWJiTLgs4sS3kSPEHvkxcCA== X-Received: by 2002:aa7:cb03:: with SMTP id s3mr30238346edt.189.1625665915179; Wed, 07 Jul 2021 06:51:55 -0700 (PDT) Received: from neptune.. ([5.2.193.191]) by smtp.gmail.com with ESMTPSA id jx1sm7036202ejc.101.2021.07.07.06.51.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 06:51:54 -0700 (PDT) From: Alexandru Ardelean To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: bgolaszewski@baylibre.com, linus.walleij@linaro.org, Alexandru Ardelean Subject: [PATCH] gpio: viperboard: remove platform_set_drvdata() call in probe Date: Wed, 7 Jul 2021 16:51:44 +0300 Message-Id: <20210707135144.191567-1-aardelean@deviqon.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The platform_set_drvdata() call is only useful if we need to retrieve back the private information. Since the driver doesn't do that, it's not useful to have it. This change removes it. Signed-off-by: Alexandru Ardelean --- drivers/gpio/gpio-viperboard.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-viperboard.c b/drivers/gpio/gpio-viperboard.c index c301c1d56dd2..98ddd6590362 100644 --- a/drivers/gpio/gpio-viperboard.c +++ b/drivers/gpio/gpio-viperboard.c @@ -422,12 +422,8 @@ static int vprbrd_gpio_probe(struct platform_device *pdev) vb_gpio->gpiob.direction_input = vprbrd_gpiob_direction_input; vb_gpio->gpiob.direction_output = vprbrd_gpiob_direction_output; ret = devm_gpiochip_add_data(&pdev->dev, &vb_gpio->gpiob, vb_gpio); - if (ret < 0) { + if (ret < 0) dev_err(vb_gpio->gpiob.parent, "could not add gpio b"); - return ret; - } - - platform_set_drvdata(pdev, vb_gpio); return ret; } -- 2.31.1