[pinctrl:devel 6/11] drivers/pinctrl/freescale/pinctrl-imx8ulp.c:228:35: warning: 'pin_reg' is used uninitialized in this function

[pinctrl:devel 6/11] drivers/pinctrl/freescale/pinctrl-imx8ulp.c:228:35: warning: 'pin_reg' is used uninitialized in this function

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2264 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
head:   79e2311c876c276566e3fb84ba33682eb540874b
commit: 16b343e8e0ef7de5ce451427fafc9e2ea42f548f [6/11] pinctrl: imx8ulp: Add pinctrl driver support
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?id=16b343e8e0ef7de5ce451427fafc9e2ea42f548f
        git remote add pinctrl https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git
        git fetch --no-tags pinctrl devel
        git checkout 16b343e8e0ef7de5ce451427fafc9e2ea42f548f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/pinctrl/freescale/pinctrl-imx8ulp.c: In function 'imx8ulp_pmx_gpio_set_direction':
>> drivers/pinctrl/freescale/pinctrl-imx8ulp.c:228:35: warning: 'pin_reg' is used uninitialized in this function [-Wuninitialized]
     228 |  reg = readl(ipctl->base + pin_reg->mux_reg);
         |                                   ^~


vim +/pin_reg +228 drivers/pinctrl/freescale/pinctrl-imx8ulp.c

   219	
   220	static int imx8ulp_pmx_gpio_set_direction(struct pinctrl_dev *pctldev,
   221						  struct pinctrl_gpio_range *range,
   222						  unsigned offset, bool input)
   223	{
   224		struct imx_pinctrl *ipctl = pinctrl_dev_get_drvdata(pctldev);
   225		const struct imx_pin_reg *pin_reg;
   226		u32 reg;
   227	
 > 228		reg = readl(ipctl->base + pin_reg->mux_reg);
   229		if (input)
   230			reg = (reg & ~BM_OBE_ENABLED) | BM_IBE_ENABLED;
   231		else
   232			reg = (reg & ~BM_IBE_ENABLED) | BM_OBE_ENABLED;
   233		writel(reg, ipctl->base + pin_reg->mux_reg);
   234	
   235		return 0;
   236	}
   237	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 77928 bytes --]

RE: [pinctrl:devel 6/11] drivers/pinctrl/freescale/pinctrl-imx8ulp.c:228:35: warning: 'pin_reg' is used uninitialized in this function

[Aisheng Dong]

> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/pinctrl/freescale/pinctrl-imx8ulp.c: In function
> 'imx8ulp_pmx_gpio_set_direction':
> >> drivers/pinctrl/freescale/pinctrl-imx8ulp.c:228:35: warning:
> >> 'pin_reg' is used uninitialized in this function [-Wuninitialized]
>      228 |  reg = readl(ipctl->base + pin_reg->mux_reg);
>          |                                   ^~
> 

Jacky,
Can you fix it ASAP?

Regards
Aisheng

> 
> vim +/pin_reg +228 drivers/pinctrl/freescale/pinctrl-imx8ulp.c
> 
>    219
>    220	static int imx8ulp_pmx_gpio_set_direction(struct pinctrl_dev
> *pctldev,
>    221						  struct pinctrl_gpio_range *range,
>    222						  unsigned offset, bool input)
>    223	{
>    224		struct imx_pinctrl *ipctl = pinctrl_dev_get_drvdata(pctldev);
>    225		const struct imx_pin_reg *pin_reg;
>    226		u32 reg;
>    227
>  > 228		reg = readl(ipctl->base + pin_reg->mux_reg);
>    229		if (input)
>    230			reg = (reg & ~BM_OBE_ENABLED) | BM_IBE_ENABLED;
>    231		else
>    232			reg = (reg & ~BM_IBE_ENABLED) | BM_OBE_ENABLED;
>    233		writel(reg, ipctl->base + pin_reg->mux_reg);
>    234
>    235		return 0;
>    236	}
>    237
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.
> org%2Fhyperkitty%2Flist%2Fkbuild-all%40lists.01.org&amp;data=04%7C01%7
> Caisheng.dong%40nxp.com%7C77d8ecb2644540665db008d94e14a97e%7C6
> 86ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637626675696342246%
> 7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=YorpxeyuRjKeWxAJVEx6
> xU9NmffBzS1Le3VkyQ8gPAA%3D&amp;reserved=0