* [PATCH] gpio: ucb1400: Use proper header
@ 2021-08-20 22:24 Linus Walleij
2021-08-21 7:38 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2021-08-20 22:24 UTC (permalink / raw)
To: linux-gpio, Bartosz Golaszewski; +Cc: Linus Walleij
The UCB1400 implements a GPIO driver so it needs to include the
<linux/gpio/driver.h> header, not the legacy <linux/gpio.h> header.
Compile tested on pxa_defconfig.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpio-ucb1400.c | 1 +
include/linux/ucb1400.h | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-ucb1400.c b/drivers/gpio/gpio-ucb1400.c
index d2a8644864c3..ab495095e9bc 100644
--- a/drivers/gpio/gpio-ucb1400.c
+++ b/drivers/gpio/gpio-ucb1400.c
@@ -7,6 +7,7 @@
#include <linux/module.h>
#include <linux/ucb1400.h>
+#include <linux/gpio/driver.h>
static int ucb1400_gpio_dir_in(struct gpio_chip *gc, unsigned off)
{
diff --git a/include/linux/ucb1400.h b/include/linux/ucb1400.h
index 0968ef458447..3a333652184f 100644
--- a/include/linux/ucb1400.h
+++ b/include/linux/ucb1400.h
@@ -23,7 +23,7 @@
#include <sound/ac97_codec.h>
#include <linux/mutex.h>
#include <linux/platform_device.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
/*
* UCB1400 AC-link registers
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: ucb1400: Use proper header
2021-08-20 22:24 [PATCH] gpio: ucb1400: Use proper header Linus Walleij
@ 2021-08-21 7:38 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2021-08-21 7:38 UTC (permalink / raw)
To: Linus Walleij; +Cc: open list:GPIO SUBSYSTEM, Bartosz Golaszewski
On Sat, Aug 21, 2021 at 1:27 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> The UCB1400 implements a GPIO driver so it needs to include the
> <linux/gpio/driver.h> header, not the legacy <linux/gpio.h> header.
> Compile tested on pxa_defconfig.
...
> #include <linux/module.h>
> #include <linux/ucb1400.h>
> +#include <linux/gpio/driver.h>
Can you add it in an order?
...
> --- a/include/linux/ucb1400.h
> +++ b/include/linux/ucb1400.h
> @@ -23,7 +23,7 @@
> #include <sound/ac97_codec.h>
> #include <linux/mutex.h>
> #include <linux/platform_device.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
Ditto (to some extent) and the question here, do you still need it
after adding to the C file?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] gpio: ucb1400: Use proper header
@ 2022-08-31 8:47 Linus Walleij
2022-08-31 11:37 ` Bartosz Golaszewski
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2022-08-31 8:47 UTC (permalink / raw)
To: linux-gpio, Bartosz Golaszewski; +Cc: Linus Walleij
The UCB1400 implements a GPIO driver so it needs to include the
<linux/gpio/driver.h> header, not the legacy <linux/gpio.h> header.
Compile tested on pxa_defconfig.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpio-ucb1400.c | 1 +
include/linux/ucb1400.h | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-ucb1400.c b/drivers/gpio/gpio-ucb1400.c
index 386e69300332..676adf1f198a 100644
--- a/drivers/gpio/gpio-ucb1400.c
+++ b/drivers/gpio/gpio-ucb1400.c
@@ -7,6 +7,7 @@
#include <linux/module.h>
#include <linux/ucb1400.h>
+#include <linux/gpio/driver.h>
static int ucb1400_gpio_dir_in(struct gpio_chip *gc, unsigned off)
{
diff --git a/include/linux/ucb1400.h b/include/linux/ucb1400.h
index 22345391350b..2516082cd3a9 100644
--- a/include/linux/ucb1400.h
+++ b/include/linux/ucb1400.h
@@ -23,7 +23,7 @@
#include <sound/ac97_codec.h>
#include <linux/mutex.h>
#include <linux/platform_device.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
/*
* UCB1400 AC-link registers
--
2.37.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-31 11:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-20 22:24 [PATCH] gpio: ucb1400: Use proper header Linus Walleij
2021-08-21 7:38 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2022-08-31 8:47 Linus Walleij
2022-08-31 11:37 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).