From: Kalle Valo <kvalo@codeaurora.org>
To: Miaoqing Pan <miaoqing@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com,
dan.carpenter@oracle.com, linux-gpio@vger.kernel.org,
Miaoqing Pan <miaoqing@codeaurora.org>
Subject: Re: [PATCH] ath9k: fix sleeping in atomic context
Date: Sun, 29 Aug 2021 07:12:41 +0000 (UTC) [thread overview]
Message-ID: <20210829071241.B0FA5C43460@smtp.codeaurora.org> (raw)
In-Reply-To: <1628481916-15030-1-git-send-email-miaoqing@codeaurora.org>
Miaoqing Pan <miaoqing@codeaurora.org> wrote:
> The problem is that gpio_free() can sleep and the cfg_soc() can be
> called with spinlocks held. One problematic call tree is:
>
> --> ath_reset_internal() takes &sc->sc_pcu_lock spin lock
> --> ath9k_hw_reset()
> --> ath9k_hw_gpio_request_in()
> --> ath9k_hw_gpio_request()
> --> ath9k_hw_gpio_cfg_soc()
>
> Remove gpio_free(), use error message instead, so we should make sure
> there is no GPIO conflict.
>
> Also remove ath9k_hw_gpio_free() from ath9k_hw_apply_gpio_override(),
> as gpio_mask will never be set for SOC chips.
>
> Signed-off-by: Miaoqing Pan <miaoqing@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
7c48662b9d56 ath9k: fix sleeping in atomic context
--
https://patchwork.kernel.org/project/linux-wireless/patch/1628481916-15030-1-git-send-email-miaoqing@codeaurora.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-08-29 7:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 4:05 [PATCH] ath9k: fix sleeping in atomic context Miaoqing Pan
2021-08-29 7:12 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210829071241.B0FA5C43460@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miaoqing@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).