From: Shreeya Patel <shreeya.patel@collabora.com>
To: linus.walleij@linaro.org, bgolaszewski@baylibre.com, wsa@kernel.org
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
Shreeya Patel <shreeya.patel@collabora.com>
Subject: [PATCH] gpio: Return EPROBE_DEFER if gc->to_irq is NULL
Date: Thu, 14 Oct 2021 16:34:37 +0530 [thread overview]
Message-ID: <20211014110437.64764-1-shreeya.patel@collabora.com> (raw)
We are racing the registering of .to_irq when probing the
i2c driver. This results in random failure of touchscreen
devices.
Following errors could be seen in dmesg logs when gc->to_irq is NULL
[2.101857] i2c_hid i2c-FTS3528:00: HID over i2c has not been provided an Int IRQ
[2.101953] i2c_hid: probe of i2c-FTS3528:00 failed with error -22
To avoid this situation, defer probing until to_irq is registered.
This issue has been reported many times in past and people have been
using workarounds like changing the pinctrl_amd to built-in instead
of loading it as a module or by adding a softdep for pinctrl_amd into
the config file.
References :-
https://bugzilla.kernel.org/show_bug.cgi?id=209413
https://github.com/Syniurge/i2c-amd-mp2/issues/3
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
---
drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 27c07108496d..fc0ba85f4c45 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -3084,7 +3084,7 @@ int gpiod_to_irq(const struct gpio_desc *desc)
return retirq;
}
- return -ENXIO;
+ return -EPROBE_DEFER;
}
EXPORT_SYMBOL_GPL(gpiod_to_irq);
--
2.30.2
next reply other threads:[~2021-10-14 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 11:04 Shreeya Patel [this message]
2021-10-14 16:51 ` [PATCH] gpio: Return EPROBE_DEFER if gc->to_irq is NULL Linus Walleij
2021-10-18 22:14 ` Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014110437.64764-1-shreeya.patel@collabora.com \
--to=shreeya.patel@collabora.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).