* Re: [PATCH] gpio: xgs-iproc: fix parsing of ngpios property
2021-10-14 12:33 [PATCH] gpio: xgs-iproc: fix parsing of ngpios property Jonas Gorski
@ 2021-10-17 23:21 ` Chris Packham
2021-10-22 19:29 ` Florian Fainelli
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Chris Packham @ 2021-10-17 23:21 UTC (permalink / raw)
To: Jonas Gorski, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Linus Walleij, Bartosz Golaszewski, Ray Jui, Scott Branden,
bcm-kernel-feedback-list@broadcom.com
On 15/10/21 1:33 am, Jonas Gorski wrote:
> of_property_read_u32 returns 0 on success, not true, so we need to
> invert the check to actually take over the provided ngpio value.
>
> Fixes: 6a41b6c5fc20 ("gpio: Add xgs-iproc driver")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Hmm I must have copied some error handling code and failed to invert the
condition when I made the property optional.
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> This is based on
> git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git,
> which is the tree for GPIO according to MAINTAINERS, but hasn't been
> updated since ~5.11 - is this still the correct tree?
>
> It doesn't matter much for this patch though, the driver is virtually
> untouched since then.
>
> drivers/gpio/gpio-xgs-iproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xgs-iproc.c b/drivers/gpio/gpio-xgs-iproc.c
> index ad5489a65d54..dd40277b9d06 100644
> --- a/drivers/gpio/gpio-xgs-iproc.c
> +++ b/drivers/gpio/gpio-xgs-iproc.c
> @@ -224,7 +224,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> }
>
> chip->gc.label = dev_name(dev);
> - if (of_property_read_u32(dn, "ngpios", &num_gpios))
> + if (!of_property_read_u32(dn, "ngpios", &num_gpios))
> chip->gc.ngpio = num_gpios;
>
> irq = platform_get_irq(pdev, 0);
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] gpio: xgs-iproc: fix parsing of ngpios property
2021-10-14 12:33 [PATCH] gpio: xgs-iproc: fix parsing of ngpios property Jonas Gorski
2021-10-17 23:21 ` Chris Packham
@ 2021-10-22 19:29 ` Florian Fainelli
2021-10-24 23:49 ` Linus Walleij
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2021-10-22 19:29 UTC (permalink / raw)
To: Jonas Gorski, linux-gpio, linux-arm-kernel
Cc: Linus Walleij, Bartosz Golaszewski, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Chris Packham
On 10/14/21 5:33 AM, Jonas Gorski wrote:
> of_property_read_u32 returns 0 on success, not true, so we need to
> invert the check to actually take over the provided ngpio value.
>
> Fixes: 6a41b6c5fc20 ("gpio: Add xgs-iproc driver")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] gpio: xgs-iproc: fix parsing of ngpios property
2021-10-14 12:33 [PATCH] gpio: xgs-iproc: fix parsing of ngpios property Jonas Gorski
2021-10-17 23:21 ` Chris Packham
2021-10-22 19:29 ` Florian Fainelli
@ 2021-10-24 23:49 ` Linus Walleij
2021-10-25 8:12 ` Bartosz Golaszewski
2021-10-31 13:24 ` Andy Shevchenko
4 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2021-10-24 23:49 UTC (permalink / raw)
To: Jonas Gorski
Cc: open list:GPIO SUBSYSTEM, Linux ARM, Bartosz Golaszewski, Ray Jui,
Scott Branden, bcm-kernel-feedback-list, Chris Packham
On Thu, Oct 14, 2021 at 2:33 PM Jonas Gorski <jonas.gorski@gmail.com> wrote:
> of_property_read_u32 returns 0 on success, not true, so we need to
> invert the check to actually take over the provided ngpio value.
>
> Fixes: 6a41b6c5fc20 ("gpio: Add xgs-iproc driver")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] gpio: xgs-iproc: fix parsing of ngpios property
2021-10-14 12:33 [PATCH] gpio: xgs-iproc: fix parsing of ngpios property Jonas Gorski
` (2 preceding siblings ...)
2021-10-24 23:49 ` Linus Walleij
@ 2021-10-25 8:12 ` Bartosz Golaszewski
2021-10-31 13:24 ` Andy Shevchenko
4 siblings, 0 replies; 7+ messages in thread
From: Bartosz Golaszewski @ 2021-10-25 8:12 UTC (permalink / raw)
To: Jonas Gorski
Cc: open list:GPIO SUBSYSTEM, Linux ARM, Linus Walleij,
Bartosz Golaszewski, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Chris Packham
On Thu, Oct 14, 2021 at 2:33 PM Jonas Gorski <jonas.gorski@gmail.com> wrote:
>
> of_property_read_u32 returns 0 on success, not true, so we need to
> invert the check to actually take over the provided ngpio value.
>
> Fixes: 6a41b6c5fc20 ("gpio: Add xgs-iproc driver")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> ---
> This is based on
> git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git,
> which is the tree for GPIO according to MAINTAINERS, but hasn't been
> updated since ~5.11 - is this still the correct tree?
>
> It doesn't matter much for this patch though, the driver is virtually
> untouched since then.
>
> drivers/gpio/gpio-xgs-iproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xgs-iproc.c b/drivers/gpio/gpio-xgs-iproc.c
> index ad5489a65d54..dd40277b9d06 100644
> --- a/drivers/gpio/gpio-xgs-iproc.c
> +++ b/drivers/gpio/gpio-xgs-iproc.c
> @@ -224,7 +224,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> }
>
> chip->gc.label = dev_name(dev);
> - if (of_property_read_u32(dn, "ngpios", &num_gpios))
> + if (!of_property_read_u32(dn, "ngpios", &num_gpios))
> chip->gc.ngpio = num_gpios;
>
> irq = platform_get_irq(pdev, 0);
> --
> 2.33.0
>
Queued for fixes.
Bart
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] gpio: xgs-iproc: fix parsing of ngpios property
2021-10-14 12:33 [PATCH] gpio: xgs-iproc: fix parsing of ngpios property Jonas Gorski
` (3 preceding siblings ...)
2021-10-25 8:12 ` Bartosz Golaszewski
@ 2021-10-31 13:24 ` Andy Shevchenko
2021-11-02 13:09 ` Bartosz Golaszewski
4 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2021-10-31 13:24 UTC (permalink / raw)
To: Jonas Gorski
Cc: open list:GPIO SUBSYSTEM, linux-arm Mailing List, Linus Walleij,
Bartosz Golaszewski, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Chris Packham
On Thu, Oct 14, 2021 at 3:48 PM Jonas Gorski <jonas.gorski@gmail.com> wrote:
>
> of_property_read_u32 returns 0 on success, not true, so we need to
> invert the check to actually take over the provided ngpio value.
> - if (of_property_read_u32(dn, "ngpios", &num_gpios))
> + if (!of_property_read_u32(dn, "ngpios", &num_gpios))
> chip->gc.ngpio = num_gpios;
Just a side note: I'm wondering how many of such we have in the
drivers and why we can't simply do it under the OF GPIO library's hood
for everybody.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] gpio: xgs-iproc: fix parsing of ngpios property
2021-10-31 13:24 ` Andy Shevchenko
@ 2021-11-02 13:09 ` Bartosz Golaszewski
0 siblings, 0 replies; 7+ messages in thread
From: Bartosz Golaszewski @ 2021-11-02 13:09 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Jonas Gorski, open list:GPIO SUBSYSTEM, linux-arm Mailing List,
Linus Walleij, Bartosz Golaszewski, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Chris Packham
On Sun, Oct 31, 2021 at 2:25 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Thu, Oct 14, 2021 at 3:48 PM Jonas Gorski <jonas.gorski@gmail.com> wrote:
> >
> > of_property_read_u32 returns 0 on success, not true, so we need to
> > invert the check to actually take over the provided ngpio value.
>
> > - if (of_property_read_u32(dn, "ngpios", &num_gpios))
> > + if (!of_property_read_u32(dn, "ngpios", &num_gpios))
> > chip->gc.ngpio = num_gpios;
>
> Just a side note: I'm wondering how many of such we have in the
> drivers and why we can't simply do it under the OF GPIO library's hood
> for everybody.
>
> --
> With Best Regards,
> Andy Shevchenko
Looks like we have 17, so yes, definitely a candidate for pulling into
the GPIO core.
Bart
^ permalink raw reply [flat|nested] 7+ messages in thread