* [PATCH] dt-bindings: gpio: sifive,gpio: Group interrupt tuples
@ 2021-11-25 15:20 Geert Uytterhoeven
2021-11-26 1:22 ` Linus Walleij
2021-12-01 8:31 ` Bartosz Golaszewski
0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-11-25 15:20 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring, Palmer Dabbelt,
Paul Walmsley, Yash Shah
Cc: linux-gpio, devicetree, linux-riscv, Geert Uytterhoeven
To improve human readability and enable automatic validation, the tuples
in "interrupts" properties should be grouped using angle brackets.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Documentation/devicetree/bindings/gpio/sifive,gpio.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
index c2902aac25145205..e04349567eebb72c 100644
--- a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
@@ -77,7 +77,8 @@ examples:
gpio@10060000 {
compatible = "sifive,fu540-c000-gpio", "sifive,gpio0";
interrupt-parent = <&plic>;
- interrupts = <7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22>;
+ interrupts = <7>, <8>, <9>, <10>, <11>, <12>, <13>, <14>, <15>, <16>,
+ <17>, <18>, <19>, <20>, <21>, <22>;
reg = <0x10060000 0x1000>;
clocks = <&tlclk PRCI_CLK_TLCLK>;
gpio-controller;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: gpio: sifive,gpio: Group interrupt tuples
2021-11-25 15:20 [PATCH] dt-bindings: gpio: sifive,gpio: Group interrupt tuples Geert Uytterhoeven
@ 2021-11-26 1:22 ` Linus Walleij
2021-11-26 7:47 ` Geert Uytterhoeven
2021-12-01 8:31 ` Bartosz Golaszewski
1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2021-11-26 1:22 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Bartosz Golaszewski, Rob Herring, Palmer Dabbelt, Paul Walmsley,
Yash Shah, linux-gpio, devicetree, linux-riscv
On Thu, Nov 25, 2021 at 4:20 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> To improve human readability and enable automatic validation, the tuples
> in "interrupts" properties should be grouped using angle brackets.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
(...)
> - interrupts = <7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22>;
> + interrupts = <7>, <8>, <9>, <10>, <11>, <12>, <13>, <14>, <15>, <16>,
> + <17>, <18>, <19>, <20>, <21>, <22>;
Tuples? Hm they look single. Like singletons?
Anyway:
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: gpio: sifive,gpio: Group interrupt tuples
2021-11-26 1:22 ` Linus Walleij
@ 2021-11-26 7:47 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-11-26 7:47 UTC (permalink / raw)
To: Linus Walleij
Cc: Bartosz Golaszewski, Rob Herring, Palmer Dabbelt, Paul Walmsley,
Yash Shah, open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-riscv
Hi Linus,
On Fri, Nov 26, 2021 at 2:22 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, Nov 25, 2021 at 4:20 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > To improve human readability and enable automatic validation, the tuples
> > in "interrupts" properties should be grouped using angle brackets.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> (...)
> > - interrupts = <7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22>;
> > + interrupts = <7>, <8>, <9>, <10>, <11>, <12>, <13>, <14>, <15>, <16>,
> > + <17>, <18>, <19>, <20>, <21>, <22>;
>
> Tuples? Hm they look single. Like singletons?
Yeah, plic has #interrupt-cells = <1>.
> Anyway:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: gpio: sifive,gpio: Group interrupt tuples
2021-11-25 15:20 [PATCH] dt-bindings: gpio: sifive,gpio: Group interrupt tuples Geert Uytterhoeven
2021-11-26 1:22 ` Linus Walleij
@ 2021-12-01 8:31 ` Bartosz Golaszewski
1 sibling, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2021-12-01 8:31 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linus Walleij, Rob Herring, Palmer Dabbelt, Paul Walmsley,
Yash Shah, open list:GPIO SUBSYSTEM, devicetree, linux-riscv
On Thu, Nov 25, 2021 at 4:20 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> To improve human readability and enable automatic validation, the tuples
> in "interrupts" properties should be grouped using angle brackets.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Documentation/devicetree/bindings/gpio/sifive,gpio.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
> index c2902aac25145205..e04349567eebb72c 100644
> --- a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
> @@ -77,7 +77,8 @@ examples:
> gpio@10060000 {
> compatible = "sifive,fu540-c000-gpio", "sifive,gpio0";
> interrupt-parent = <&plic>;
> - interrupts = <7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22>;
> + interrupts = <7>, <8>, <9>, <10>, <11>, <12>, <13>, <14>, <15>, <16>,
> + <17>, <18>, <19>, <20>, <21>, <22>;
> reg = <0x10060000 0x1000>;
> clocks = <&tlclk PRCI_CLK_TLCLK>;
> gpio-controller;
> --
> 2.25.1
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-01 8:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-25 15:20 [PATCH] dt-bindings: gpio: sifive,gpio: Group interrupt tuples Geert Uytterhoeven
2021-11-26 1:22 ` Linus Walleij
2021-11-26 7:47 ` Geert Uytterhoeven
2021-12-01 8:31 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).