Re: [PATCH v2,1/5] pinctrl: qcom: spmi-gpio: Add pm8226 compatibility

Re: [PATCH v2,1/5] pinctrl: qcom: spmi-gpio: Add pm8226 compatibility

[Dominik Kobinski]

True. Sorry for the confusion and thank you for applying the patch.

Regards,
Dominik Kobinski

[PATCH v2,0/5] Add pm8226 SPMI regulators

[Dominik Kobinski]

This series enables pm8226 SPMI regulators commonly used on msm8x26 platforms.
It is a v2 of this series : https://patchwork.kernel.org/project/linux-arm-msm/list/?series=584741

Changes since v1:
 - Add spmi regulators node in qcom-pm8226.dtsi to enable probing them.

Dominik Kobinski (5):
  pinctrl: qcom: spmi-gpio: Add pm8226 compatibility
  dt-bindings: pinctrl: qcom: pmic-gpio: Document pm8226 compatible
  dt-bindings: regulator: qcom: spmi-regulator: Document pm8226
    compatible
  regulator: qcom_spmi: Add pm8226 regulators
  arm: dts: qcom: pm8226: Support SPMI regulators on PMIC sid 1

 .../bindings/pinctrl/qcom,pmic-gpio.yaml      |  1 +
 .../regulator/qcom,spmi-regulator.txt         |  1 +
 arch/arm/boot/dts/qcom-pm8226.dtsi            |  4 ++
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c      |  1 +
 drivers/regulator/qcom_spmi-regulator.c       | 39 +++++++++++++++++++
 5 files changed, 46 insertions(+)

-- 
2.34.0

[PATCH v2,1/5] pinctrl: qcom: spmi-gpio: Add pm8226 compatibility

[Dominik Kobinski]

Add support for pm8226 SPMI GPIOs. The PMIC features
8 GPIOs, with no holes inbetween.

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Suggested-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com>
---
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 5283d5e9e8bc..0f0102f38cbb 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1159,6 +1159,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
 	/* pm8150l has 12 GPIOs with holes on 7 */
 	{ .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
 	{ .compatible = "qcom,pmc8180c-gpio", .data = (void *) 12 },
+	{ .compatible = "qcom,pm8226-gpio", .data = (void *) 8 },
 	{ .compatible = "qcom,pm8350-gpio", .data = (void *) 10 },
 	{ .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 },
 	{ .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 },
-- 
2.34.0

Re: [PATCH v2,1/5] pinctrl: qcom: spmi-gpio: Add pm8226 compatibility

[Linus Walleij]

On Thu, Nov 25, 2021 at 10:53 PM Dominik Kobinski
<dominikkobinski314@gmail.com> wrote:

> Add support for pm8226 SPMI GPIOs. The PMIC features
> 8 GPIOs, with no holes inbetween.
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Suggested-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com>

I applied this to the pinctrl tree.

Is there anything else I should be applying?

Yours,
Linus Walleij

Re: [PATCH v2,1/5] pinctrl: qcom: spmi-gpio: Add pm8226 compatibility

[Dominik Kobinski]

From: Dominik Kobinski <dkobinski314@gmail.com>

Thank you for applying the patch. I believe the second one in this series (https://patchwork.kernel.org/project/linux-arm-msm/patch/20211125215626.62447-1-dominikkobinski314@gmail.com/) should be also applied to the pinctrl tree.

Regards,
Dominik Kobinski

Re: [PATCH v2,1/5] pinctrl: qcom: spmi-gpio: Add pm8226 compatibility

[Linus Walleij]

On Fri, Nov 26, 2021 at 5:37 PM Dominik Kobinski
<dominikkobinski314@gmail.com> wrote:

> From: Dominik Kobinski <dkobinski314@gmail.com>
>
> Thank you for applying the patch. I believe the second one in this series (https://patchwork.kernel.org/project/linux-arm-msm/patch/20211125215626.62447-1-dominikkobinski314@gmail.com/) should be also applied to the pinctrl tree.

Looks like the regulator tree should take this one?
It is a regulator binding...

Yours,
Linus Walleij

Re: [PATCH v2,1/5] pinctrl: qcom: spmi-gpio: Add pm8226 compatibility

[Linus Walleij]

On Sat, Nov 27, 2021 at 2:37 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Fri, Nov 26, 2021 at 5:37 PM Dominik Kobinski
> <dominikkobinski314@gmail.com> wrote:
>
> > From: Dominik Kobinski <dkobinski314@gmail.com>
> >
> > Thank you for applying the patch. I believe the second one in this series (https://patchwork.kernel.org/project/linux-arm-msm/patch/20211125215626.62447-1-dominikkobinski314@gmail.com/) should be also applied to the pinctrl tree.
>
> Looks like the regulator tree should take this one?
> It is a regulator binding...

Oh no the one on the link, right :/
I have already applied that one?

Yours,
Linus Walleij

Re: [PATCH v2,1/5] pinctrl: qcom: spmi-gpio: Add pm8226 compatibility

[Matti Lehtimäki]

On 26.11.2021 2.49, Linus Walleij wrote:
> On Thu, Nov 25, 2021 at 10:53 PM Dominik Kobinski
> <dominikkobinski314@gmail.com> wrote:
> 
>> Add support for pm8226 SPMI GPIOs. The PMIC features
>> 8 GPIOs, with no holes inbetween.
>>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Suggested-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
>> Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com>
> 
> I applied this to the pinctrl tree.
> 
> Is there anything else I should be applying?
> 
> Yours,
> Linus Walleij

I noticed that this patch was never applied into kernel while the other 
patches such as the device tree documentation were applied. Maybe it was 
missed accidentally? I checked also the pinctrl tree and didn't find the 
commit there either in the branches for the upcoming releases.

-Matti

Re: [PATCH v2,1/5] pinctrl: qcom: spmi-gpio: Add pm8226 compatibility

[Linus Walleij]

On Fri, Jul 8, 2022 at 9:43 PM Matti Lehtimäki
<matti.lehtimaki@gmail.com> wrote:
>
> On 26.11.2021 2.49, Linus Walleij wrote:
> > On Thu, Nov 25, 2021 at 10:53 PM Dominik Kobinski
> > <dominikkobinski314@gmail.com> wrote:
> >
> >> Add support for pm8226 SPMI GPIOs. The PMIC features
> >> 8 GPIOs, with no holes inbetween.
> >>
> >> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> >> Suggested-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> >> Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com>
> >
> > I applied this to the pinctrl tree.
> >
> > Is there anything else I should be applying?
> >
> > Yours,
> > Linus Walleij
>
> I noticed that this patch was never applied into kernel while the other
> patches such as the device tree documentation were applied. Maybe it was
> missed accidentally? I checked also the pinctrl tree and didn't find the
> commit there either in the branches for the upcoming releases.

Weird I applied it now.

Yours,
Linus Walleij