From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Cosmin Tanislav <demonsingur@gmail.com>,
cosmin.tanislav@analog.com, Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <michael.hennerich@analog.com>,
Rob Herring <robh+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v6 2/3] dt-bindings: iio: add AD74413R
Date: Sat, 27 Nov 2021 18:55:56 +0000 [thread overview]
Message-ID: <20211127185556.5d91fd83@jic23-huawei> (raw)
In-Reply-To: <CACRpkdY6gCz3X_DWUj+BZEeMYGHN3T2ty5Kq7_W+Hq3jgjaKjw@mail.gmail.com>
On Sat, 27 Nov 2021 02:23:26 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> On Fri, Nov 26, 2021 at 5:03 PM Cosmin Tanislav <demonsingur@gmail.com> wrote:
>
> > + adi,rsense-resistance-ohms:
> > + description:
> > + RSense resistance values in Ohms.
>
> This description is very terse. If it is existing for the same purpose as
> shunt-resistor-micro-ohms in
> Documentation/devicetree/bindings/iio/afe/current-sense-shunt.yaml
> then you should just recycle the standard binding
> shunt-resistor-micro-ohms instead of inventing this custom one.
Good point. I'd forgotten about that one. We had to make that generic
as a current sense shunt inherently doesn't have a vendor :)
Thanks Linus!
Jonathan
>
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2021-11-27 18:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 16:02 [PATCH v6 0/3] Add AD74413R driver Cosmin Tanislav
2021-11-26 16:02 ` [PATCH v6 1/3] iio: add adddac subdirectory Cosmin Tanislav
2021-11-26 16:02 ` [PATCH v6 2/3] dt-bindings: iio: add AD74413R Cosmin Tanislav
2021-11-27 1:23 ` Linus Walleij
2021-11-27 18:55 ` Jonathan Cameron [this message]
2021-11-26 16:02 ` [PATCH v6 3/3] iio: addac: add AD74413R driver Cosmin Tanislav
2021-11-27 1:36 ` Linus Walleij
2021-11-27 18:46 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211127185556.5d91fd83@jic23-huawei \
--to=jic23@kernel.org \
--cc=brgl@bgdev.pl \
--cc=cosmin.tanislav@analog.com \
--cc=demonsingur@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).