From: Phil Elwell <phil@raspberrypi.com>
To: Rob Herring <robh+dt@kernel.org>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
Linus Walleij <linus.walleij@linaro.org>,
Phil Elwell <phil@raspberrypi.com>,
Thierry Reding <treding@nvidia.com>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org
Subject: [PATCH v2 0/2] pinctrl: bcm2835: Fix gpio hogs and pin reinitialisation
Date: Mon, 6 Dec 2021 09:22:35 +0000 [thread overview]
Message-ID: <20211206092237.4105895-1-phil@raspberrypi.com> (raw)
Tackle two problems with the pinctrl-bcm2835 driver and its Device Tree
configuration:
1. The pinctrl-bcm2835 driver is a combined pinctrl/gpio driver.
Currently the gpio side is registered first, but this breaks gpio hogs
(which are configured during gpiochip_add_data).
2. Since [1], a "gpio-ranges" property is required in order for pins
to be returned to inputs when freed. Note that without patch 1, the
device never gets out of EPROBE_DEFER.
Note that the Fixes: tags are little more than hooks to hang the back-ports
on - no blame is intended.
[1] commit 2ab73c6d8323 ("gpio: Support GPIO controllers without
pin-ranges")
Changes in v2:
* Removed wrapping of Fixes: tags.
* Added Reviewed-by from Linus, who asks that Patch 2 be merged through the
Broadcom/SoC tree.
* Corrected Nicolas's email address.
Phil Elwell (2):
pinctrl: bcm2835: Change init order for gpio hogs
ARM: dts: gpio-ranges property is now required
arch/arm/boot/dts/bcm2711.dtsi | 2 ++
arch/arm/boot/dts/bcm283x.dtsi | 2 ++
drivers/pinctrl/bcm/pinctrl-bcm2835.c | 29 +++++++++++++++------------
3 files changed, 20 insertions(+), 13 deletions(-)
--
2.25.1
next reply other threads:[~2021-12-06 9:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 9:22 Phil Elwell [this message]
2021-12-06 9:22 ` [PATCH v2 1/2] pinctrl: bcm2835: Change init order for gpio hogs Phil Elwell
2021-12-07 18:32 ` Florian Fainelli
2021-12-09 23:24 ` Linus Walleij
2021-12-29 19:07 ` Stefan Wahren
2021-12-29 21:11 ` Florian Fainelli
2022-01-02 6:54 ` Linus Walleij
2022-01-02 11:02 ` Jan Kiszka
2022-01-02 12:33 ` Stefan Wahren
2022-01-02 15:12 ` Jan Kiszka
2022-01-02 15:16 ` Jan Kiszka
2022-01-04 17:04 ` Linus Walleij
2021-12-06 9:22 ` [PATCH v2 2/2] ARM: dts: gpio-ranges property is now required Phil Elwell
2021-12-06 10:33 ` Linus Walleij
2021-12-06 17:24 ` Florian Fainelli
2021-12-07 15:29 ` Linus Walleij
2021-12-10 11:12 ` nicolas saenz julienne
[not found] ` <CGME20211214142139eucas1p1c100b7fd4b8c8ce85bc03e1ce6b783db@eucas1p1.samsung.com>
2021-12-14 14:21 ` Marek Szyprowski
2021-12-14 14:32 ` Phil Elwell
2021-12-14 17:12 ` Florian Fainelli
2021-12-15 9:02 ` nicolas saenz julienne
2021-12-15 17:14 ` Florian Fainelli
2021-12-16 3:27 ` Linus Walleij
2021-12-16 3:28 ` Florian Fainelli
2021-12-16 3:31 ` Linus Walleij
2021-12-16 8:28 ` nicolas saenz julienne
2021-12-15 17:15 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206092237.4105895-1-phil@raspberrypi.com \
--to=phil@raspberrypi.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).